emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jesse Johnson <bbuknight@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: inherit priority
Date: Mon, 08 Jan 2018 14:16:45 +0100	[thread overview]
Message-ID: <87r2r05w3m.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <cc99c4a6-4c7d-19e1-ffef-1157deb96ab2@gmail.com> (Jesse Johnson's message of "Sun, 7 Jan 2018 14:47:20 -0800")

Hello,

Jesse Johnson <bbuknight@gmail.com> writes:

> I am trying to determine the functions I need to add / update to
> respect priority inheritance.
>
> I see that org-show-priority would need to be updated,

Correct, but that would be a minor change.

> and likely
> a new function, say org-get-priority-with-inheritance, should
> supplement org-get-priority.

I think you need to change `org-get-priority' signature. You can remove
the string argument and possibly add an optional argument: a buffer
position. It should handle inheritance without any additional function,
if a global variable, e.g., `org-priority-use-inheritance' is non-nil.

Note that you can already achieve inheritance by setting
`org-get-priority-function' to a function that searches priority cookies
among ancestors of the current headline.

> However, I can't figure out where org-colview is getting the priority
> from.

From `org-entry-get' -> `org-entry-properties'.

I don't think there's any change involved in "org-colview.el".

> I also don't know where sorting is considering priority.
>
> Help with pointing me in the right direction for either of those would
> be much appreciated! Also let me know if other things touching
> priority need updating for inheritance.

You should start with `org-get-priority'. Most things are going to work
once it is updated.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2018-01-08 13:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-31 18:14 inherit priority Jesse Johnson
2018-01-03 21:41 ` Nicolas Goaziou
2018-01-04  4:04   ` Jesse Johnson
2018-01-04  8:15     ` Nicolas Goaziou
2018-01-05  4:00       ` Jesse Johnson
2018-01-05  7:24         ` Nicolas Goaziou
2018-01-07 22:47           ` Jesse Johnson
2018-01-08 13:16             ` Nicolas Goaziou [this message]
2018-04-26 23:34         ` Bastien
2018-04-27  1:34           ` Jesse Johnson
2018-04-27  1:59             ` Bastien
2018-07-08  1:55               ` Jesse Johnson
2018-07-09  8:22                 ` Nicolas Goaziou
2018-07-10  5:03                   ` Jesse Johnson
2018-07-18 12:54                     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2r05w3m.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=bbuknight@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).