emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: org-map-entries calls org-agenda-prepare-buffers unnecessarily?
Date: Tue, 26 Jun 2018 18:19:00 +0200	[thread overview]
Message-ID: <87r2ktr05n.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <878t73jyow.fsf@alphapapa.net> (Adam Porter's message of "Sun, 24 Jun 2018 23:07:59 -0500")

Hello,

Adam Porter <adam@alphapapa.net> writes:

> I've noticed that org-map-entries calls org-agenda-prepare-buffers
> whenever its SCOPE argument is nil.  According to the docstring, a nil
> SCOPE means, "The current buffer, respecting the restriction if any," so
> it doesn't seem necessary to call org-agenda-prepare-buffers.

Here be dragons!

> I noticed this because I have a function in my org-mode-hook that runs
> org-map-entries (applying a read-only property to entries with a
> read_only tag), and whenever I find-file on a non-existent Org file, I'm
> prompted, "Non-existent agenda file %s.  [R]emove from list or
> [A]bort?", which is caused by org-map-entries being called with a nil
> SCOPE, which calls org-agenda-prepare-buffers, which calls
> org-check-agenda-file on the not-yet-existent file.  So if this behavior
> is indeed unnecessary, it would be nice to fix it.

For simple cases like yours, I suggest to map over headlines manually,
e.g., 

  (goto-char (point-min))
  (unless (org-at-heading-p) (outline-next-heading))
  (while (not (eobp))
   ... do stuff...)

> Is this a bug, or am I missing something?

Neither. `org-map-entries' is a complex function that arguably does more
than it should.

Regards,

-- 
Nicolas Goaziou

     prev parent reply	other threads:[~2018-06-26 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25  4:07 org-map-entries calls org-agenda-prepare-buffers unnecessarily? Adam Porter
2018-06-26 16:19 ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2ktr05n.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).