* org-map-entries calls org-agenda-prepare-buffers unnecessarily?
@ 2018-06-25 4:07 Adam Porter
2018-06-26 16:19 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Adam Porter @ 2018-06-25 4:07 UTC (permalink / raw)
To: emacs-orgmode
Hi,
I've noticed that org-map-entries calls org-agenda-prepare-buffers
whenever its SCOPE argument is nil. According to the docstring, a nil
SCOPE means, "The current buffer, respecting the restriction if any," so
it doesn't seem necessary to call org-agenda-prepare-buffers.
I noticed this because I have a function in my org-mode-hook that runs
org-map-entries (applying a read-only property to entries with a
read_only tag), and whenever I find-file on a non-existent Org file, I'm
prompted, "Non-existent agenda file %s. [R]emove from list or
[A]bort?", which is caused by org-map-entries being called with a nil
SCOPE, which calls org-agenda-prepare-buffers, which calls
org-check-agenda-file on the not-yet-existent file. So if this behavior
is indeed unnecessary, it would be nice to fix it.
Is this a bug, or am I missing something?
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: org-map-entries calls org-agenda-prepare-buffers unnecessarily?
2018-06-25 4:07 org-map-entries calls org-agenda-prepare-buffers unnecessarily? Adam Porter
@ 2018-06-26 16:19 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2018-06-26 16:19 UTC (permalink / raw)
To: Adam Porter; +Cc: emacs-orgmode
Hello,
Adam Porter <adam@alphapapa.net> writes:
> I've noticed that org-map-entries calls org-agenda-prepare-buffers
> whenever its SCOPE argument is nil. According to the docstring, a nil
> SCOPE means, "The current buffer, respecting the restriction if any," so
> it doesn't seem necessary to call org-agenda-prepare-buffers.
Here be dragons!
> I noticed this because I have a function in my org-mode-hook that runs
> org-map-entries (applying a read-only property to entries with a
> read_only tag), and whenever I find-file on a non-existent Org file, I'm
> prompted, "Non-existent agenda file %s. [R]emove from list or
> [A]bort?", which is caused by org-map-entries being called with a nil
> SCOPE, which calls org-agenda-prepare-buffers, which calls
> org-check-agenda-file on the not-yet-existent file. So if this behavior
> is indeed unnecessary, it would be nice to fix it.
For simple cases like yours, I suggest to map over headlines manually,
e.g.,
(goto-char (point-min))
(unless (org-at-heading-p) (outline-next-heading))
(while (not (eobp))
... do stuff...)
> Is this a bug, or am I missing something?
Neither. `org-map-entries' is a complex function that arguably does more
than it should.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-26 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-25 4:07 org-map-entries calls org-agenda-prepare-buffers unnecessarily? Adam Porter
2018-06-26 16:19 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).