emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: stardiviner <numbchild@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [BUG] Recently master branch commit breaks open file: link
Date: Mon, 24 Feb 2020 21:30:45 +0100	[thread overview]
Message-ID: <87r1yj683u.fsf@gnu.org> (raw)
In-Reply-To: <87imjwf2ee.fsf@gmail.com> (stardiviner's message of "Mon, 24 Feb 2020 23:09:13 +0800")

Hi Stardiviner,

stardiviner <numbchild@gmail.com> writes:

>> IMHO we may have several file links such as yours broken: Nicolas,
>> do you think the bugfix should be advertized in ORG-NEWS, along with
>> a helper function to fix file links (ie remove the TODO keyword and
>> priority cookies)?
>
> This broken update might need a little think.
>
> The new org-store-link does not include the TODO keyword. But what if user add
> keyword before, then later does not use it in Org Mode config. This TODO keyword
> will caused broken.

You can run something like this command in your org files, it will
prompt you for the fixed link:

(defun org-fix-links ()
  "Fix ill-formatted internal links.
E.g. replace [[*TODO Headline][headline]] by [[*Headline][headline]].
Go through the buffer and ask for the replacement."
  (interactive)
  (visible-mode 1)
  (save-excursion
    (goto-char (point-min))
    (while (re-search-forward org-link-any-re nil t)
      (let* ((raw (match-string 2))
	     (desc (match-string 3))
	     fix new)
	(when (and raw desc
		   (string-match-p
		    (concat "^\*" (regexp-opt org-todo-keywords-1)
			    "\\s-+\\(.+\\)$")
		    raw))
	  (setq new (replace-regexp-in-string
		     (concat (regexp-opt org-todo-keywords-1) "\\s-+")
		     "" raw))
	  (set-text-properties 0 (length new) nil new)
	  (setq fix (completing-read "Replace link at point by: "
				     nil nil nil new))
	  (replace-match (format "[[%s][%s]]" fix desc))))))
  (visible-mode -1))

HTH,

-- 
 Bastien

  reply	other threads:[~2020-02-24 20:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24  6:38 stardiviner
2020-02-24  8:41 ` Bastien
2020-02-24 12:06   ` stardiviner
2020-02-24 12:15     ` Bastien
2020-02-24 15:09       ` stardiviner
2020-02-24 20:30         ` Bastien [this message]
2020-02-24 20:35         ` Document backward-incompatible change in ORG-NEWS? (was: [BUG] Recently master branch commit breaks open file: link) Bastien
2020-02-24 21:31           ` Samuel Wales
2020-02-25  7:02             ` stardiviner
2020-02-25  9:10           ` Document backward-incompatible change in ORG-NEWS? Nicolas Goaziou
2020-02-25 19:34             ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r1yj683u.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=numbchild@gmail.com \
    --subject='Re: [BUG] Recently master branch commit breaks open file: link' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).