emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: mail <mail@nicolasgoaziou.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Document backward-incompatible change in ORG-NEWS? (was: [BUG] Recently master branch commit breaks open file: link)
Date: Mon, 24 Feb 2020 21:35:14 +0100	[thread overview]
Message-ID: <874kvf67wd.fsf_-_@gnu.org> (raw)
In-Reply-To: <87imjwf2ee.fsf@gmail.com> (stardiviner's message of "Mon, 24 Feb 2020 23:09:13 +0800")

Hi Nicolas,

it seems that org-store-link stored links to headlines as

[[*TODO headline][headline]]

keeping the TODO keyword, if any.

This is fixed in master but I won't if we should document this bug
fix in ORG-NEWS (or if org-store-link was just momentarily broken.)

If org-store-link was storing the todo keyword, perhaps we can add
a command similar to this one to help users fix broken links:

(defun org-fix-links ()
  "Fix ill-formatted internal links.
E.g. replace [[*TODO Headline][headline]] by [[*Headline][headline]].
Go through the buffer and ask for the replacement."
  (interactive)
  (visible-mode 1)
  (save-excursion
    (goto-char (point-min))
    (while (re-search-forward org-link-any-re nil t)
      (let* ((raw (match-string 2))
	     (desc (match-string 3))
	     fix new)
	(when (and raw desc
		   (string-match-p
		    (concat "^\*" (regexp-opt org-todo-keywords-1)
			    "\\s-+\\(.+\\)$")
		    raw))
	  (setq new (replace-regexp-in-string
		     (concat (regexp-opt org-todo-keywords-1) "\\s-+")
		     "" raw))
	  (set-text-properties 0 (length new) nil new)
	  (setq fix (completing-read "Replace link at point by: "
				     nil nil nil new))
	  (replace-match (format "[[%s][%s]]" fix desc))))))
  (visible-mode -1))

WDYT?

-- 
 Bastien

  parent reply	other threads:[~2020-02-24 20:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-24  6:38 [BUG] Recently master branch commit breaks open file: link stardiviner
2020-02-24  8:41 ` Bastien
2020-02-24 12:06   ` stardiviner
2020-02-24 12:15     ` Bastien
2020-02-24 15:09       ` stardiviner
2020-02-24 20:30         ` Bastien
2020-02-24 20:35         ` Bastien [this message]
2020-02-24 21:31           ` Document backward-incompatible change in ORG-NEWS? (was: [BUG] Recently master branch commit breaks open file: link) Samuel Wales
2020-02-25  7:02             ` stardiviner
2020-02-25  9:10           ` Document backward-incompatible change in ORG-NEWS? Nicolas Goaziou
2020-02-25 19:34             ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kvf67wd.fsf_-_@gnu.org \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    --subject='Re: Document backward-incompatible change in ORG-NEWS? (was: [BUG] Recently master branch commit breaks open file: link)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).