emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [BUG] Agenda query trailing spaces [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)]
@ 2021-11-17  5:48 Carlos Pita
  2021-11-17 14:24 ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Carlos Pita @ 2021-11-17  5:48 UTC (permalink / raw)
  To: emacs-orgmode

Hi all,

when I press [ or ] to add additional words to the agenda query but then
immediately abort the prompt with C-g without actually adding any new
word, a trailing extra space is added to the query. After doing the same
n times, the query includes n trailing spaces.

Best regards,
Carlos

------------------------------------------------------------------------


Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-apple-darwin20.6.0, NS appkit-2022.60 Version 11.6 (Build 20G165))
 of 2021-11-14
Package: Org mode version 9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)

current state:
==============
(setq
 org-link-elisp-confirm-function 'yes-or-no-p
 org-directory "~/Documents"
 org-bibtex-headline-format-function '(closure
                                       (org-id-locations org-agenda-search-view-always-boolean org-agenda-overriding-header
                                        t)
                                       (entry) (cdr (assq :title entry)))
 org-persist-after-read-hook '(org-element--cache-persist-after-read)
 org-export-before-parsing-hook '(org-attach-expand-links)
 org-default-notes-file "~/Documents/Capturas.org"
 org-archive-hook '(org-attach-archive-delete-maybe)
 org-cycle-hook '(org-cycle-hide-archived-subtrees org-cycle-hide-drawers org-cycle-show-empty-lines
                  org-optimize-window-after-visibility-change)
 org-persist-before-read-hook '(org-element--cache-persist-before-read)
 org-mode-hook '((closure
                  (org-agenda-skip-regexp org-table1-hline-regexp org-table-tab-recognizes-table\.el
                   org-table-dataline-regexp org-table-any-border-regexp org-agenda-restriction-lock-overlay
                   org-agenda-overriding-restriction org-agenda-diary-file org-complex-heading-regexp t)
                  nil (setq imenu-create-index-function 'org-imenu-get-tree))
                 (closure
                  (org--rds reftex-docstruct-symbol org-element-greater-elements visual-fill-column-width org-clock-history
                   org-agenda-current-date org-with-time org-defdecode org-def org-read-date-inactive org-ans2 org-ans1
                   org-columns-current-fmt-compiled org-clock-current-task org-clock-effort org-agenda-skip-function
                   org-agenda-skip-comment-trees org-agenda-archives-mode org-end-time-was-given org-time-was-given
                   org-log-note-extra org-log-note-purpose org-log-post-message org-last-inserted-timestamp
                   org-last-changed-timestamp org-entry-property-inherited-from org-blocked-by-checkboxes org-state
                   org-agenda-headline-snapshot-before-repeat org-agenda-buffer-name org-agenda-start-on-weekday
                   org-agenda-buffer-tmp-name org-priority-regexp org-mode-abbrev-table org-mode-syntax-table
                   org-element-use-cache org-element-cache-persistent buffer-face-mode-face org-tbl-menu org-org-menu
                   org-struct-menu org-entities org-last-state org-id-track-globally org-clock-start-time texmathp-why
                   remember-data-file org-agenda-tags-todo-honor-ignore-options iswitchb-temp-buflist
                   calc-embedded-open-mode calc-embedded-open-formula calc-embedded-close-formula align-mode-rules-list
                   org-emphasis-alist org-emphasis-regexp-components org-export-registered-backends org-modules
                   crm-separator org-babel-load-languages org-id-overriding-file-name org-indent-indentation-per-level
                   org-element-paragraph-separate org-agenda-buffer-name org-inlinetask-min-level t)
                  nil (add-hook 'change-major-mode-hook 'org-show-all 'append 'local))
                 (closure
                  (org-src-window-setup *this* org-babel-confirm-evaluate-answer-no org-babel-tangle-uncomment-comments
                   org-src-preserve-indentation org-src-lang-modes org-edit-src-content-indentation
                   org-babel-library-of-babel t)
                  nil (add-hook 'change-major-mode-hook #'org-babel-show-result-all 'append 'local))
                 org-babel-result-hide-spec org-babel-hide-all-hashes)
 org-confirm-shell-link-function 'yes-or-no-p
 org-reveal-start-hook '(org-decrypt-entry)
 outline-isearch-open-invisible-function 'outline-isearch-open-invisible
 org-agenda-before-write-hook '(org-agenda-add-entry-text)
 org-src-mode-hook '(org-src-babel-configure-edit-buffer org-src-mode-configure-edit-buffer)
 org-confirm-elisp-link-function 'yes-or-no-p
 org-cycle-separator-lines 1
 org-todo-keywords '((sequence "TODO" "NEXT" "|" "DONE"))
 outline-minor-mode-buttons '(("▶" "▼" outline--valid-char-p))
 org-support-shift-select t
 org-speed-command-hook '(org-speed-command-activate org-babel-speed-command-activate)
 org-preview-latex-default-process 'dvisvgm
 org-persist-before-write-hook '(org-element--cache-persist-before-write)
 org-tab-first-hook '(org-babel-hide-result-toggle-maybe org-babel-header-arg-expand)
 org-link-shell-confirm-function 'yes-or-no-p
 org-babel-pre-tangle-hook '(save-buffer)
 org-agenda-loop-over-headlines-in-active-region nil
 org-occur-hook '(org-first-headline-recenter)
 org-metadown-hook '(org-babel-pop-to-session-maybe)
 org-link-parameters '(("attachment" :follow org-attach-follow :complete org-attach-complete-link)
                       ("id" :follow org-id-open) ("eww" :follow org-eww-open :store org-eww-store-link)
                       ("rmail" :follow org-rmail-open :store org-rmail-store-link)
                       ("mhe" :follow org-mhe-open :store org-mhe-store-link)
                       ("irc" :follow org-irc-visit :store org-irc-store-link :export org-irc-export)
                       ("info" :follow org-info-open :export org-info-export :store org-info-store-link)
                       ("gnus" :follow org-gnus-open :store org-gnus-store-link)
                       ("docview" :follow org-docview-open :export org-docview-export :store org-docview-store-link)
                       ("bibtex" :follow org-bibtex-open :store org-bibtex-store-link)
                       ("bbdb" :follow org-bbdb-open :export org-bbdb-export :complete org-bbdb-complete-link :store
                        org-bbdb-store-link)
                       ("w3m" :store org-w3m-store-link) ("doi" :follow org-link-doi-open :export org-link-doi-export)
                       ("file+sys") ("file+emacs") ("shell" :follow org-link--open-shell)
                       ("news" :follow
                        (closure
                         ((scheme . "news") (--dolist-tail--) org-ts-regexp org-time-stamp-formats org-src-source-file-name
                          org-outline-regexp-bol org-inhibit-startup org-id-link-to-org-use-id org-highlight-links
                          org-comment-string org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
                         (url arg) (browse-url (concat scheme ":" url) arg))
                        )
                       ("mailto" :follow
                        (closure
                         ((scheme . "mailto") (--dolist-tail--) org-ts-regexp org-time-stamp-formats
                          org-src-source-file-name org-outline-regexp-bol org-inhibit-startup org-id-link-to-org-use-id
                          org-highlight-links org-comment-string org-agenda-buffer-name clean-buffer-list-kill-buffer-names
                          t)
                         (url arg) (browse-url (concat scheme ":" url) arg))
                        )
                       ("https" :follow
                        (closure
                         ((scheme . "https") (--dolist-tail--) org-ts-regexp org-time-stamp-formats org-src-source-file-name
                          org-outline-regexp-bol org-inhibit-startup org-id-link-to-org-use-id org-highlight-links
                          org-comment-string org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
                         (url arg) (browse-url (concat scheme ":" url) arg))
                        )
                       ("http" :follow
                        (closure
                         ((scheme . "http") (--dolist-tail--) org-ts-regexp org-time-stamp-formats org-src-source-file-name
                          org-outline-regexp-bol org-inhibit-startup org-id-link-to-org-use-id org-highlight-links
                          org-comment-string org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
                         (url arg) (browse-url (concat scheme ":" url) arg))
                        )
                       ("ftp" :follow
                        (closure
                         ((scheme . "ftp") (--dolist-tail--) org-ts-regexp org-time-stamp-formats org-src-source-file-name
                          org-outline-regexp-bol org-inhibit-startup org-id-link-to-org-use-id org-highlight-links
                          org-comment-string org-agenda-buffer-name clean-buffer-list-kill-buffer-names t)
                         (url arg) (browse-url (concat scheme ":" url) arg))
                        )
                       ("help" :follow org-link--open-help :store org-link--store-help)
                       ("file" :complete org-link-complete-file) ("elisp" :follow org-link--open-elisp))
 org-metaup-hook '(org-babel-load-in-session-maybe)
 )


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG] Agenda query trailing spaces [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)]
  2021-11-17  5:48 [BUG] Agenda query trailing spaces [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)] Carlos Pita
@ 2021-11-17 14:24 ` Ihor Radchenko
  2024-04-22 13:45   ` Ihor Radchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2021-11-17 14:24 UTC (permalink / raw)
  To: Carlos Pita; +Cc: emacs-orgmode

Carlos Pita <carlosjosepita2@gmail.com> writes:

> when I press [ or ] to add additional words to the agenda query but then
> immediately abort the prompt with C-g without actually adding any new
> word, a trailing extra space is added to the query. After doing the same
> n times, the query includes n trailing spaces.

Confirmed

However, this behaviour seems to be partially intentional. It was
explicitly introduced in 774964adb. So, the fix may not be
straightforward. Someone needs to study the relevant agenda code.

Best,
Ihor



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [BUG] Agenda query trailing spaces [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)]
  2021-11-17 14:24 ` Ihor Radchenko
@ 2024-04-22 13:45   ` Ihor Radchenko
  0 siblings, 0 replies; 3+ messages in thread
From: Ihor Radchenko @ 2024-04-22 13:45 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: Carlos Pita, emacs-orgmode

Ihor Radchenko <yantar92@gmail.com> writes:

> Confirmed
>
> However, this behaviour seems to be partially intentional. It was
> explicitly introduced in 774964adb. So, the fix may not be
> straightforward. Someone needs to study the relevant agenda code.

Fixed, on bugfix.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0db82ee8f

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-22 13:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-17  5:48 [BUG] Agenda query trailing spaces [9.5 (release_9.5-225-g494c20.dirty @ /Users/carlos/Install/Source/org-mode/lisp/)] Carlos Pita
2021-11-17 14:24 ` Ihor Radchenko
2024-04-22 13:45   ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).