From: Ihor Radchenko <yantar92@posteo.net>
To: Hugo Cisneros <hmj.cisneros@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: [PATCH] Throw an error when bibliography field is not properly parsed (was: [PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON.)
Date: Thu, 29 Dec 2022 14:21:06 +0000 [thread overview]
Message-ID: <87r0withnx.fsf@localhost> (raw)
In-Reply-To: <87edsnsocj.fsf@localhost>
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Ihor Radchenko <yantar92@posteo.net> writes:
>> As explained in the ChangeLog entry, this points to a more general issue where
>> `org-cite-basic--get-field' is expected to return nil or a string, but calls
>> `org-cite-basic--get-entry' that may return an association list. I am not sure
>> how to fix that since it means converting anything that
>> `org-cite-basic--get-entry' may return into a string.
>
> Non-string can only be for JSON bibliographies for fields that are not
> supported. `org-cite-basic--get-field' can probably return nil in such
> scenarios.
I am attaching tentative patch that will make
`org-cite-basic--get-field' throw an error when the filed value is not a
string.
I would appreciate testing.
Best,
Ihor
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org-cite-basic-get-field-Throw-an-error-on-non-nil-f.patch --]
[-- Type: text/x-patch, Size: 1584 bytes --]
From 9fe6284fdc7ceeb0e0aa8e5a58b6828ca415b6b2 Mon Sep 17 00:00:00 2001
Message-Id: <9fe6284fdc7ceeb0e0aa8e5a58b6828ca415b6b2.1672323564.git.yantar92@posteo.net>
From: Ihor Radchenko <yantar92@posteo.net>
Date: Thu, 29 Dec 2022 17:18:35 +0300
Subject: [PATCH] org-cite-basic--get-field: Throw an error on non-nil field
values
* lisp/oc-basic.el (org-cite-basic--get-field): Throw an error when
the field value is not a string. Document the new behavior.
Link: https://orgmode.org/list/87edsnsocj.fsf@localhost
---
lisp/oc-basic.el | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el
index 01e314bfd..8e69db03c 100644
--- a/lisp/oc-basic.el
+++ b/lisp/oc-basic.el
@@ -332,7 +332,9 @@ (defun org-cite-basic--get-field (field entry-or-key &optional info raw)
Return value may be nil or a string. If current export back-end is derived
from `latex', return a raw string instead, unless optional argument RAW is
-non-nil."
+non-nil.
+
+Throw an error if the field value is non-string and non-nil."
(let ((value
(cdr
(assq field
@@ -343,6 +345,8 @@ (defun org-cite-basic--get-field (field entry-or-key &optional info raw)
entry-or-key)
(_
(error "Wrong value for ENTRY-OR-KEY: %S" entry-or-key)))))))
+ (unless (and value (stringp value))
+ (error "Non-string bibliography field value: %S" value))
(if (and value
(not raw)
(org-export-derived-backend-p (plist-get info :back-end) 'latex))
--
2.38.1
[-- Attachment #3: Type: text/plain, Size: 225 bytes --]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-12-29 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 17:03 [PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON Hugo Cisneros
2022-12-25 11:40 ` Ihor Radchenko
2022-12-29 14:21 ` Ihor Radchenko [this message]
2023-01-17 12:26 ` [PATCH] Throw an error when bibliography field is not properly parsed (was: [PATCH] oc-basic.el: Fix wrong type for the editors field when parsing JSON.) Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0withnx.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=hmj.cisneros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).