emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

* [BUG] org-mobile: Arguments of expand-file-name are flipped [9.6.20 ( @ /home/fb/.config/emacs/elpa/org-9.6.20/)]
@ 2024-03-02 18:28 Fabian Brosda
  2024-03-06 10:38 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Brosda @ 2024-03-02 18:28 UTC (permalink / raw)
  To: emacs-orgmode

Hi,

just a very small issue I found, as I was wondering, why the agendas
file was included in the index, although it did not exist.

The problem is in org-mobile.el in Line 473, as the arguments to
expand-file-name are in the wrong order:

(when (file-exists-p (expand-file-name
			    org-mobile-directory "agendas.org"))

Linking to the exact spot on github:
https://github.com/bzg/org-mode/blob/main/lisp/org-mobile.el#L473

Would be great, if someone could fix this. All other uses of
expand-file-name in there seem to be fine.

Best regards

Fabian

Emacs  : GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40, cairo version 1.18.0)
Package: Org mode version 9.6.20 ( @ /home/fb/.config/emacs/elpa/org-9.6.20/)


^ permalink raw reply	[flat|nested] 2+ messages in thread

• * Re: [BUG] org-mobile: Arguments of expand-file-name are flipped [9.6.20 ( @ /home/fb/.config/emacs/elpa/org-9.6.20/)]
    2024-03-02 18:28 [BUG] org-mobile: Arguments of expand-file-name are flipped [9.6.20 ( @ /home/fb/.config/emacs/elpa/org-9.6.20/)] Fabian Brosda
  @ 2024-03-06 10:38 ` Ihor Radchenko
    0 siblings, 0 replies; 2+ messages in thread
  From: Ihor Radchenko @ 2024-03-06 10:38 UTC (permalink / raw)
    To: Fabian Brosda; +Cc: emacs-orgmode
  
  Fabian Brosda <f.brosda@gmx.de> writes:
  
  > just a very small issue I found, as I was wondering, why the agendas
  > file was included in the index, although it did not exist.
  >
  > The problem is in org-mobile.el in Line 473, as the arguments to
  > expand-file-name are in the wrong order:
  >
  > (when (file-exists-p (expand-file-name
  > 			    org-mobile-directory "agendas.org"))
  >
  
  Thanks for reporting!
  Fixed, on main.
  https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=8eb78048f
  
  -- 
  Ihor Radchenko // yantar92,
  Org mode contributor,
  Learn more about Org mode at <https://orgmode.org/>.
  Support Org development at <https://liberapay.com/org-mode>,
  or support my work at <https://liberapay.com/yantar92>
  
  
  ^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-06 10:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-02 18:28 [BUG] org-mobile: Arguments of expand-file-name are flipped [9.6.20 ( @ /home/fb/.config/emacs/elpa/org-9.6.20/)] Fabian Brosda
2024-03-06 10:38 ` Ihor Radchenko

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).