* (require 'htmlize) in org-exp should have NOERROR set
@ 2008-11-17 0:25 Daniel Clemente
2008-11-17 4:54 ` Carsten Dominik
0 siblings, 1 reply; 5+ messages in thread
From: Daniel Clemente @ 2008-11-17 0:25 UTC (permalink / raw)
To: emacs-orgmode
With org-mode 6.12a from Emacs 23 of 15-11-2008, I get the error
(file-error "Cannot open load file" "htmlize")
when exporting to HTML this file:
----
#+BEGIN_SRC emacs-lisp
; beeeeep
(beep)
#+END_SRC
----
The problem seems to be in org-export-format-source-code (org-exp.el):
;; We are exporting to HTML
(condition-case nil (require 'htmlize) (nil t))
That should be just (require 'htmlize nil t)
I have also seen the idiom (condition-case nil (require 'htmlize) (error t)), but I think (require 'htmlize nil t) is cleaner because it doesn't throw errors.
-- Daniel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (require 'htmlize) in org-exp should have NOERROR set
2008-11-17 0:25 (require 'htmlize) in org-exp should have NOERROR set Daniel Clemente
@ 2008-11-17 4:54 ` Carsten Dominik
2008-11-17 8:46 ` Paul R
0 siblings, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2008-11-17 4:54 UTC (permalink / raw)
To: Daniel Clemente; +Cc: emacs-orgmode
Fixed, thanks.
- Carsten
On Nov 17, 2008, at 1:25 AM, Daniel Clemente wrote:
>
> With org-mode 6.12a from Emacs 23 of 15-11-2008, I get the error
> (file-error "Cannot open load file" "htmlize")
> when exporting to HTML this file:
>
> ----
> #+BEGIN_SRC emacs-lisp
> ; beeeeep
> (beep)
> #+END_SRC
> ----
>
> The problem seems to be in org-export-format-source-code (org-
> exp.el):
>
> ;; We are exporting to HTML
> (condition-case nil (require 'htmlize) (nil t))
>
> That should be just (require 'htmlize nil t)
> I have also seen the idiom (condition-case nil (require 'htmlize)
> (error t)), but I think (require 'htmlize nil t) is cleaner because
> it doesn't throw errors.
>
>
>
> -- Daniel
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (require 'htmlize) in org-exp should have NOERROR set
2008-11-17 4:54 ` Carsten Dominik
@ 2008-11-17 8:46 ` Paul R
2008-11-17 8:52 ` Carsten Dominik
0 siblings, 1 reply; 5+ messages in thread
From: Paul R @ 2008-11-17 8:46 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Hi,
Carsten> Fixed, thanks. - Carsten
So you have a working version of htmlize for emacs 23 ? The one on
emacswiki is broken with emacs 23 AFAICT.
regards,
--
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (require 'htmlize) in org-exp should have NOERROR set
2008-11-17 8:46 ` Paul R
@ 2008-11-17 8:52 ` Carsten Dominik
2008-11-17 10:06 ` Paul R
0 siblings, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2008-11-17 8:52 UTC (permalink / raw)
To: Paul R; +Cc: emacs-orgmode
On Nov 17, 2008, at 9:46 AM, Paul R wrote:
> Hi,
>
> Carsten> Fixed, thanks. - Carsten
>
> So you have a working version of htmlize for emacs 23 ? The one on
> emacswiki is broken with emacs 23 AFAICT.
This works for me:
--- htmlize.el.orig 2008-10-20 18:59:21.000000000 +0200
+++ htmlize.el 2008-10-20 18:59:50.000000000 +0200
@@ -867,7 +867,7 @@
(let ((size-list
(loop
for f = face then (face-attribute f :inherit)
- until (eq f 'unspecified)
+ until (or (not f) (eq f 'unspecified))
for h = (face-attribute f :height)
collect (if (eq h 'unspecified) nil h))))
(reduce 'htmlize-merge-size (cons nil size-list))))
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: (require 'htmlize) in org-exp should have NOERROR set
2008-11-17 8:52 ` Carsten Dominik
@ 2008-11-17 10:06 ` Paul R
0 siblings, 0 replies; 5+ messages in thread
From: Paul R @ 2008-11-17 10:06 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Carsten> This works for me:
Fine so I'm dropping it on emacswiki. Thanks
--
Paul
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-11-17 10:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-17 0:25 (require 'htmlize) in org-exp should have NOERROR set Daniel Clemente
2008-11-17 4:54 ` Carsten Dominik
2008-11-17 8:46 ` Paul R
2008-11-17 8:52 ` Carsten Dominik
2008-11-17 10:06 ` Paul R
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).