From: Sebastian Rose <sebastian_rose@gmx.de>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: Org-mode version 6.32b; org-remember only indents first line of %i substitution
Date: Fri, 20 Nov 2009 23:10:17 +0100 [thread overview]
Message-ID: <87pr7cetkm.fsf@gmx.de> (raw)
In-Reply-To: <DD23969D-F3E8-4DF9-A89E-8939153A2C8A@gmail.com> (Carsten Dominik's message of "Fri, 20 Nov 2009 06:48:38 +0100")
Carsten Dominik <carsten.dominik@gmail.com> writes:
> Hi Sebastian - I am confused - which is the patch I should apply?
Sorry Carsten. The I CCed you with - the second one. It takes into
account, that the title could be empty too.
It's in the mail you're replying to.
>> [[url][ ]]
>>
>>
>> Test:
>>
>>
>> (let ((orglink (org-make-link-string
>> "http://www.google.de" " ")))
>> (insert orglink))
>> Which is invisible in Org-files!!!
>
> I have fixed this also, in a diffeerent way.
>
> - Carsten
Great.
This patch:
>> diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
>> index 5c65fb0..0d40c2c 100644
>> --- a/lisp/org-protocol.el
>> +++ b/lisp/org-protocol.el
>> @@ -470,9 +470,10 @@ Now template ?b will be used."
>> (url (org-protocol-sanitize-uri (car parts)))
>> (type (if (string-match "^\\([a-z]+\\):" url)
>> (match-string 1 url)))
>> - (title (cadr parts))
>> - (region (caddr parts))
>> - (orglink (org-make-link-string url title))
>> + (title (or (cadr parts) ""))
>> + (region (or (caddr parts) ""))
>> + (orglink (org-make-link-string
>> + url (if (string-match "[^[:space:]]" title) title url)))
>> remember-annotation-functions)
>> (setq org-stored-links
>> (cons (list url title) org-stored-links))
Best
Sebastian
prev parent reply other threads:[~2009-11-20 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 15:27 Org-mode version 6.32b; org-remember only indents first line of %i substitution Andrew J. Korty
2009-11-18 22:54 ` Carsten Dominik
2009-11-19 21:22 ` Andrew J. Korty
2009-11-19 22:24 ` Sebastian Rose
2009-11-19 22:47 ` Sebastian Rose
2009-11-20 5:48 ` Carsten Dominik
2009-11-20 22:10 ` Sebastian Rose [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pr7cetkm.fsf@gmx.de \
--to=sebastian_rose@gmx.de \
--cc=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).