From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian Rose <sebastian_rose@gmx.de>
Subject: Re: Org-mode version 6.32b; org-remember only indents first line of
 %i substitution
Date: Fri, 20 Nov 2009 23:10:17 +0100
Message-ID: <87pr7cetkm.fsf@gmx.de>
References: <649C26F5-AB40-4757-86A9-658FEBB08CD6@iu.edu>
	<A601D0F5-326C-40AC-8FBB-83932FFB7E0F@gmail.com>
	<A2973C82-953D-486C-B4F1-4E22A9F074B6@iu.edu> <87zl6ijfn2.fsf@gmx.de>
	<DD23969D-F3E8-4DF9-A89E-8939153A2C8A@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NBbga-0003MO-TA
	for emacs-orgmode@gnu.org; Fri, 20 Nov 2009 17:10:36 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NBbgV-0003Gk-HY
	for emacs-orgmode@gnu.org; Fri, 20 Nov 2009 17:10:36 -0500
Received: from [199.232.76.173] (port=51639 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NBbgT-0003ES-JE
	for emacs-orgmode@gnu.org; Fri, 20 Nov 2009 17:10:29 -0500
Received: from mail.gmx.net ([213.165.64.20]:37934)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <sebastian_rose@gmx.de>) id 1NBbgT-0001jB-2C
	for emacs-orgmode@gnu.org; Fri, 20 Nov 2009 17:10:29 -0500
In-Reply-To: <DD23969D-F3E8-4DF9-A89E-8939153A2C8A@gmail.com> (Carsten
	Dominik's message of "Fri, 20 Nov 2009 06:48:38 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Org Mode <emacs-orgmode@gnu.org>

Carsten Dominik <carsten.dominik@gmail.com> writes:
> Hi Sebastian - I am confused - which is the patch I should apply?


Sorry Carsten. The I CCed you with - the second one. It takes into
account, that the title could be empty too.

It's in the mail you're replying to.


>>  [[url][ ]]
>>
>>
>> Test:
>>
>>
>> (let ((orglink (org-make-link-string
>>                "http://www.google.de" " ")))
>>  (insert orglink))
>> Which is invisible in Org-files!!!
>
> I have fixed this also, in a diffeerent way.
>
> - Carsten


Great.



This patch:


>> diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
>> index 5c65fb0..0d40c2c 100644
>> --- a/lisp/org-protocol.el
>> +++ b/lisp/org-protocol.el
>> @@ -470,9 +470,10 @@ Now template ?b will be used."
>>              (url (org-protocol-sanitize-uri (car parts)))
>>              (type (if (string-match "^\\([a-z]+\\):" url)
>>                        (match-string 1 url)))
>> -             (title (cadr parts))
>> -             (region (caddr parts))
>> -             (orglink (org-make-link-string url title))
>> +             (title (or (cadr parts) ""))
>> +             (region (or (caddr parts) ""))
>> +             (orglink (org-make-link-string
>> +		       url (if (string-match "[^[:space:]]" title) title url)))
>>              remember-annotation-functions)
>>         (setq org-stored-links
>>               (cons (list url title) org-stored-links))



Best

  Sebastian