From: Jonas Bernoulli <jonas@bernoul.li>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: Using orgstruct-mode (or just org-cycle) in emacs-lisp-mode
Date: Thu, 19 Nov 2015 20:50:31 +0100 [thread overview]
Message-ID: <87poz5bwfs.fsf@bernoul.li> (raw)
In-Reply-To: <87d1v6l6ws.fsf@nicolasgoaziou.fr>
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Jonas Bernoulli <jonas@bernoul.li> writes:
>
>> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>
>>> Jonas Bernoulli <jonas@bernoul.li> writes:
>>>
>>>> Thanks. But could you please change it to
>>>>
>>>> (if (or outline-minor-mode orgstruct-mode)
>>>> (call-interactively #'show-children)
>>>> ...)
>>>
>>> You could set `orgstruct-mode' to a non-nil value whenever
>>> `outline-minor-mode' is enabled.
>>
>> I could (instead I am currently just maintaining a local patch),
>> but what is the reasoning for not just doing what I suggested?
>
> There is no reason for Org's core to know about `outline-minor-mode', or
> any other minor mode in the wild.
I wouldn't group `outline-minor-mode' among "any other minor mode
in the wild", after all it was Outline which gave birth to Org and
`outline-minor-mode' is part of `outline.el'. Didn't Carsten write
`outline-magic.el' (containing `outline-cycle') before moving on to
greater things? Unfortunately though `outline-magic.el' does not appear
to have aged so well (at least that's how I remember it from when I last
checked).
Anyway I think `outline-minor-mode' deserves some special attention,
but of course that's the call of the maintainers.
> IMO, using a hook is much more simple than maintaining a local patch.
Not for me. I install all packages using Git submodules, which is very
convenient because I contribute to most packages I use, at least in some
minor way like addressing compilation warnings. If a patch isn't
accepted upstream, then the only additional work required is to call
`git config branch.master.rebase true' once and then occasionally
`git push tarsius master'.
next prev parent reply other threads:[~2015-11-19 19:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 15:02 Using orgstruct-mode (or just org-cycle) in emacs-lisp-mode Jonas Bernoulli
2015-11-08 15:24 ` Nicolas Goaziou
2015-11-08 15:48 ` Jonas Bernoulli
2015-11-08 17:34 ` Aaron Ecay
2015-11-09 23:40 ` Jonas Bernoulli
2015-11-10 10:54 ` Rasmus
2015-12-01 20:06 ` Thorsten Jolitz
2015-11-08 17:36 ` Jorge A. Alfaro-Murillo
2015-11-09 23:30 ` Jonas Bernoulli
2015-11-14 8:37 ` Nicolas Goaziou
2015-11-18 9:57 ` Jonas Bernoulli
2015-11-19 8:39 ` Nicolas Goaziou
2015-11-19 19:50 ` Jonas Bernoulli [this message]
2015-11-19 21:47 ` Rasmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87poz5bwfs.fsf@bernoul.li \
--to=jonas@bernoul.li \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).