From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonas Bernoulli <jonas@bernoul.li>
Subject: Re: Using orgstruct-mode (or just org-cycle) in emacs-lisp-mode
Date: Thu, 19 Nov 2015 20:50:31 +0100
Message-ID: <87poz5bwfs.fsf@bernoul.li>
References: <87oaf4wn30.fsf@bernoul.li> <87vb9c7bui.fsf@nicolasgoaziou.fr>
	<87a8qofq62.fsf@bernoul.li> <8737w9564w.fsf@nicolasgoaziou.fr>
	<878u5vr5nj.fsf@bernoul.li> <87d1v6l6ws.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60478)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jonas@bernoul.li>) id 1ZzVEB-0001qP-Uk
	for emacs-orgmode@gnu.org; Thu, 19 Nov 2015 14:50:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jonas@bernoul.li>) id 1ZzVE8-000568-HV
	for emacs-orgmode@gnu.org; Thu, 19 Nov 2015 14:50:43 -0500
Received: from mail.hostpark.net ([212.243.197.30]:52427)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jonas@bernoul.li>) id 1ZzVE8-00055H-5Z
	for emacs-orgmode@gnu.org; Thu, 19 Nov 2015 14:50:40 -0500
In-reply-to: <87d1v6l6ws.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Jonas Bernoulli <jonas@bernoul.li> writes:
>
>> Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>>
>>> Jonas Bernoulli <jonas@bernoul.li> writes:
>>>
>>>> Thanks.  But could you please change it to
>>>>
>>>>   (if (or outline-minor-mode orgstruct-mode)
>>>>       (call-interactively #'show-children)
>>>>     ...)
>>>
>>> You could set `orgstruct-mode' to a non-nil value whenever
>>> `outline-minor-mode' is enabled.
>>
>> I could (instead I am currently just maintaining a local patch),
>> but what is the reasoning for not just doing what I suggested?
>
> There is no reason for Org's core to know about `outline-minor-mode', or
> any other minor mode in the wild.

I wouldn't group `outline-minor-mode' among "any other minor mode
in the wild", after all it was Outline which gave birth to Org and
`outline-minor-mode' is part of `outline.el'.  Didn't Carsten write
`outline-magic.el' (containing `outline-cycle') before moving on to
greater things?  Unfortunately though `outline-magic.el' does not appear
to have aged so well (at least that's how I remember it from when I last
checked).

Anyway I think `outline-minor-mode' deserves some special attention,
but of course that's the call of the maintainers.

> IMO, using a hook is much more simple than maintaining a local patch.

Not for me.  I install all packages using Git submodules, which is very
convenient because I contribute to most packages I use, at least in some
minor way like addressing compilation warnings.  If a patch isn't
accepted upstream, then the only additional work required is to call
`git config branch.master.rebase true' once and then occasionally
`git push tarsius master'.