emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Pierre Téchoueyres" <pierre.techoueyres@free.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.
Date: Tue, 13 Mar 2018 09:19:18 +0100	[thread overview]
Message-ID: <87po488k1l.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <871sgt2fk3.fsf@killashandra.ballybran.fr> ("Pierre Téchoueyres"'s message of "Fri, 09 Mar 2018 20:51:00 +0100")

Hello,

pierre.techoueyres@free.fr (Pierre Téchoueyres) writes:

> Hello all Org's developpers,
> I would like to provide a small improvement to ob-sql : the possibility to
> connect to an oracle database by using the alias defined in TNSNAMES file.
>
> The patch joined here try to achive this. It also improve (slightly) the
> data fetching by removing unwanted trailing whitespaces provided by the
> LINESIZE directive.

Thank you.

Have you signed FSF papers? Otherwise, you need to add TINYCHANGE at the
end of your message?

Otherwise, it looks good. Would you mind adding an entry in ORG-NEWS
about it?


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2018-03-13  8:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 19:51 [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql Pierre Téchoueyres
2018-03-13  8:19 ` Nicolas Goaziou [this message]
2018-03-13 12:10   ` pierre.techoueyres
2018-03-13 19:51   ` Pierre Téchoueyres
2018-03-14 13:38     ` Nicolas Goaziou
2018-03-15 18:34       ` Pierre Téchoueyres
2018-03-16 22:03         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po488k1l.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=pierre.techoueyres@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).