From: pierre.techoueyres@free.fr
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql.
Date: Tue, 13 Mar 2018 13:10:39 +0100 [thread overview]
Message-ID: <41e6e480b15a62d62fa4696d3fb0690e@free.fr> (raw)
In-Reply-To: <87po488k1l.fsf@nicolasgoaziou.fr>
> Hello,
Hello Nicolas,
>
> pierre.techoueyres@free.fr (Pierre Téchoueyres) writes:
>
>> Hello all Org's developpers,
>> I would like to provide a small improvement to ob-sql : the
>> possibility to
>> connect to an oracle database by using the alias defined in TNSNAMES
>> file.
>>
>> The patch joined here try to achive this. It also improve (slightly)
>> the
>> data fetching by removing unwanted trailing whitespaces provided by
>> the
>> LINESIZE directive.
>
> Thank you.
>
> Have you signed FSF papers? Otherwise, you need to add TINYCHANGE at
> the
> end of your message?
Normally, I've done this some time ago for TRAMP and EMACS core (I
think).
>
> Otherwise, it looks good. Would you mind adding an entry in ORG-NEWS
> about it?
>
Yes, I'll try to send a new patch soon.
>
> Regards,
next prev parent reply other threads:[~2018-03-13 12:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 19:51 [PATCH] ob-sql.el: Improve Oracle connection and usage for ob-sql Pierre Téchoueyres
2018-03-13 8:19 ` Nicolas Goaziou
2018-03-13 12:10 ` pierre.techoueyres [this message]
2018-03-13 19:51 ` Pierre Téchoueyres
2018-03-14 13:38 ` Nicolas Goaziou
2018-03-15 18:34 ` Pierre Téchoueyres
2018-03-16 22:03 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41e6e480b15a62d62fa4696d3fb0690e@free.fr \
--to=pierre.techoueyres@free.fr \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).