emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Aaron Madlon-Kay <aaron@madlon-kay.com>
Cc: emacs-orgmode@gnu.org, Juri Linkov <juri@linkov.net>
Subject: Re: [PATCH] ob-ruby.el: Don't reuse the same buffer among different named
Date: Sun, 13 Dec 2020 04:03:29 GMT	[thread overview]
Message-ID: <87pn3euzcg.fsf@kyleam.com> (raw)
In-Reply-To: <CAHvKJZsAUtYOKV1bH_r9BXqE_d6k11qg4dfxvqCUVUxjmGohGw@mail.gmail.com>

Aaron Madlon-Kay writes:

>> +                                     (run-ruby-or-pop-to-buffer
>> +                                      cmd (or session "ruby")
>> +                                      (unless session
>> +                                        (inf-ruby-buffer)))
> I have just run into an issue with this: If you don't specify :ruby
> then `cmd' for me is calculated by
>     (cdr (assoc inf-ruby-default-implementation inf-ruby-implementations))
> which gives the function `inf-ruby--irb-command' as a result.
> However `run-ruby-or-pop-to-buffer' expects to get a string only.

Thanks for noting this.  Indeed it looks like the old call through
run-ruby handled this

     (let ((command
            (or command
                (cdr (assoc inf-ruby-default-implementation
       (if (functionp command)
           (funcall command)

and that's lost with this switch to run-ruby-or-pop-to-buffer.

> I'm not sure if it should be org-mode's responsibility to resolve the
> actual command string, or if it should be done by
> `run-ruby-or-pop-to-buffer'. (It kind of seems like the latter?)
> Any thoughts?

Given the current situation, I don't see a good option aside from doing
the functionp dance in org-babel-ruby-initiate-session as well.  Even if
inf-ruby's check was moved downstream of run-ruby-or-pop-to-buffer, I
think it'd be good to fix on ob-ruby's end to work with the current

Juri, what do you think?

  reply	other threads:[~2020-12-13  4:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  8:49 Aaron Madlon-Kay
2020-10-20  8:49 ` [PATCH] ob-ruby.el: allow specification of ruby command w/header arg Aaron Madlon-Kay
2020-10-24 11:39   ` Bastien
2020-10-25  1:21     ` Aaron Madlon-Kay
2020-11-10 19:34   ` Juri Linkov
2020-11-14 21:19     ` Kyle Meyer
2020-11-25 19:41       ` Juri Linkov
2020-11-27  6:42         ` [PATCH] ob-ruby.el: Don't reuse the same buffer among different named Kyle Meyer
2020-11-28 22:23           ` Kyle Meyer
2020-12-11  7:23             ` Aaron Madlon-Kay
2020-12-13  4:03               ` Kyle Meyer [this message]
2020-12-13 19:22                 ` Juri Linkov
2020-12-13 20:00                   ` Kyle Meyer
2020-12-14  0:52                     ` Aaron Madlon-Kay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn3euzcg.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=aaron@madlon-kay.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=juri@linkov.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).