emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Juri Linkov <juri@linkov.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] ob-ruby.el: allow specification of ruby command w/header arg
Date: Sat, 14 Nov 2020 16:19:23 -0500	[thread overview]
Message-ID: <87ft5b63hg.fsf@kyleam.com> (raw)
In-Reply-To: <87y2j9j9ai.fsf@mail.linkov.net>

Juri Linkov writes:

> Thanks, this is a much needed change.  But currently it is limited only
> to non-session code execution.  Here is an additional patch that also
> supports the same feature for session code execution as well:
>
> ob-ruby.el: allow specification of session ruby command w/header arg
>
> * lisp/ob-ruby.el (org-babel-ruby-initiate-session): Use a header argument
> to get ruby command.

Thanks.

I see you applied this today in the Emacs repo (844e82f5a8).  I've
ported it to the Org repo, but please avoid doing this in the future.
The preferred method is for development to happen through Org's list and
repo.

I apologize because my word choice in bug#32676 may have caused confusion:

  Kyle Meyer writes:
  
  > Kévin Le Gouguec writes:
  >
  > That said...
  >
  >> IIUC, Org maintainers prefer for changes to be submitted to
  >> emacs-orgmode@gnu.org; they only occasionally dive into
  >> bug-gnu-emacs@gnu.org to look for open Org issues.
  >
  > ...submitting patches on the Org list is of course appreciated,
  > particularly for things that target Org rather than being part of a
  > tree-wide cleanup.

I think "appreciated" understates how strong the preference is on Org's
side.


  reply	other threads:[~2020-11-14 21:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-20  8:49 Aaron Madlon-Kay
2020-10-20  8:49 ` [PATCH] ob-ruby.el: allow specification of ruby command w/header arg Aaron Madlon-Kay
2020-10-24 11:39   ` Bastien
2020-10-25  1:21     ` Aaron Madlon-Kay
2020-11-10 19:34   ` Juri Linkov
2020-11-14 21:19     ` Kyle Meyer [this message]
2020-11-25 19:41       ` Juri Linkov
2020-11-27  6:42         ` [PATCH] ob-ruby.el: Don't reuse the same buffer among different named Kyle Meyer
2020-11-28 22:23           ` Kyle Meyer
2020-12-11  7:23             ` Aaron Madlon-Kay
2020-12-13  4:03               ` Kyle Meyer
2020-12-13 19:22                 ` Juri Linkov
2020-12-13 20:00                   ` Kyle Meyer
2020-12-14  0:52                     ` Aaron Madlon-Kay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft5b63hg.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=juri@linkov.net \
    --subject='Re: [PATCH] ob-ruby.el: allow specification of ruby command w/header arg' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).