emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Add missing `provide' in ob-octave test
@ 2022-04-27  2:01 Nick Dokos
  2022-04-27  8:58 ` Ihor Radchenko
  0 siblings, 1 reply; 2+ messages in thread
From: Nick Dokos @ 2022-04-27  2:01 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

`make test' has been failing for me with this error:

,----
| Error: error ("Loading file
| /home/nick/src/emacs/org/org-mode/testing/lisp/test-ob-octave.el
| failed to provide feature ‘test-ob-octave’")
`----

The attached patch provides a fix.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: [PATCH] Add missing `provide' in ob-octave test --]
[-- Type: text/x-patch, Size: 672 bytes --]

From dc1ab2a24bfc5a02845c380c60f0c1a7452e639a Mon Sep 17 00:00:00 2001
From: Nick Dokos <ndokos@gmail.com>
Date: Tue, 15 Mar 2022 12:33:52 -0400
Subject: [PATCH] test-ob-octave: Add missing `provide'

---
 testing/lisp/test-ob-octave.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/testing/lisp/test-ob-octave.el b/testing/lisp/test-ob-octave.el
index 7e20add99..6113b40f3 100644
--- a/testing/lisp/test-ob-octave.el
+++ b/testing/lisp/test-ob-octave.el
@@ -63,3 +63,5 @@
   (org-test-at-id "cc2d82bb-2ac0-45be-a0c8-d1463b86a3ba"
     (org-babel-next-src-block 5)
     (should (equal nil (org-babel-execute-src-block)))))
+
+(provide 'test-ob-octave)
-- 
2.34.1


[-- Attachment #3: Type: text/plain, Size: 140 bytes --]


-- 
Nick

"There are only two hard problems in computer science: cache invalidation, naming things, and off-by-one errors." -Martin Fowler

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add missing `provide' in ob-octave test
  2022-04-27  2:01 [PATCH] Add missing `provide' in ob-octave test Nick Dokos
@ 2022-04-27  8:58 ` Ihor Radchenko
  0 siblings, 0 replies; 2+ messages in thread
From: Ihor Radchenko @ 2022-04-27  8:58 UTC (permalink / raw)
  To: Nick Dokos; +Cc: emacs-orgmode

Nick Dokos <ndokos@gmail.com> writes:

> `make test' has been failing for me with this error:
>
> ,----
> | Error: error ("Loading file
> | /home/nick/src/emacs/org/org-mode/testing/lisp/test-ob-octave.el
> | failed to provide feature ‘test-ob-octave’")
> `----
>
> The attached patch provides a fix.

Thanks! Applied to main as 98a771cc3.

Best,
Ihor


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-27  9:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27  2:01 [PATCH] Add missing `provide' in ob-octave test Nick Dokos
2022-04-27  8:58 ` Ihor Radchenko

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).