emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Kenny Ballou <kb@devnulllabs.io>
Cc: yantar92@gmail.com, emacs-orgmode@gnu.org
Subject: Re: [PATCH] lisp/org-capture.el: use link ID's for %K
Date: Sun, 10 Dec 2023 12:19:21 +0000	[thread overview]
Message-ID: <87plzeqmgm.fsf@localhost> (raw)
In-Reply-To: <87zfyj7zko.fsf@devnulllabs.io>

Kenny Ballou <kb@devnulllabs.io> writes:

>> The last step is unnecessary. You may just examine `org-stored-links'
>> (documented in the docstring of `org-store-link') or
>> `org-store-link-plist' (undocumented, but containing more info and also
>> used by `org-capture-fill-template').
>
> I ended up using `org-store-link-plist'.  For some reason that I don't
> understand, the `save-excursion' -> `org-store-link' was not updating
> `org-stored-links'.

I can see it from the code now. Basically, instead of updating
`org-stored-links', `org-store-link' returns the link when called
non-interactively (with nil INTERACTIVE? argument).
Now documented on main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5e809903d

> ... Similarly, I had to use `save-window-excursion' or
> the `org-clock-goto' would really break things.

You should not use `org-clock-goto' - it is intended for interactive use
and does a lot of unnecessary work.
You may instead do (org-with-point-at org-clock-marker ...)

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-12-10 12:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 13:26 Org-capture %K "Link to the currently clocked task" link with id? Nathaniel W Griswold
2021-05-19 17:29 ` Nathaniel W Griswold
2021-05-24 12:25   ` Nathaniel W Griswold
2021-05-29  8:10     ` Ihor Radchenko
2023-12-07 18:53       ` [PATCH] lisp/org-capture.el: use link ID's for %K Kenny Ballou
2023-12-08 13:56         ` Ihor Radchenko
2023-12-08 18:47           ` Kenny Ballou
2023-12-08 19:01             ` Ihor Radchenko
2023-12-09 22:53               ` Kenny Ballou
2023-12-10 12:19                 ` Ihor Radchenko [this message]
2023-12-11 15:33                   ` Kenny Ballou
2023-12-11 15:46                   ` Kenny Ballou
     [not found]                   ` <20231211154357.23020-1-kb@devnulllabs.io>
     [not found]                     ` <87ttoo7dna.fsf@localhost>
2023-12-11 21:21                       ` Kenny Ballou
2023-12-12  4:13                         ` [PATCH] lisp/org-capture.el: use `org-store-link' for %K values Kenny Ballou
2023-12-12  4:32                           ` Kenny Ballou
2023-12-12  4:32                             ` [PATCH] lisp/org-capture.el: use `org-store-link' for %K values Kenny Ballou
2023-12-12 12:46                               ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plzeqmgm.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=kb@devnulllabs.io \
    --cc=yantar92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).