From: Kenny Ballou <kb@devnulllabs.io>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org, yantar92@gmail.com
Subject: Re: [PATCH] lisp/org-capture.el: use link ID's for %K
Date: Mon, 11 Dec 2023 14:21:41 -0700 [thread overview]
Message-ID: <87o7ew8m6f.fsf@devnulllabs.io> (raw)
In-Reply-To: <87ttoo7dna.fsf@localhost>
On 2023-12-11 19:16 GMT, Ihor Radchenko wrote:
>
>> +*** Capture template expansion now supports ID links
>> +
>> +The capture template expansion element `%K' creates links using
>> +`org-store-link', which respects the values of
>> +`org-id-link-to-use-id'.
>
> Here, we simply use Org markup. So, =%K=, ~org-store-link~, and ~org-id-link-to-use-id~.
> See doc/Documentation_Standards.org for details.
I'll update for the new patch version.
>
>> + (save-excursion
>
> `save-excursion' should be unnecessary here. `org-with-point-at' already
> takes care about restoring window configuration and point.
>
Correct, I'll remove it. The patch is now much simpler :)
>> + (org-with-point-at org-clock-marker
>> + (substring-no-properties (org-store-link current-prefix-arg nil))))
>> ""))
>
> Using `current-prefix-arg' is incorrect here.
> `org-capture-fill-template' is called from `org-capture' that assigns a
> completely different meaning to the prefix argument (see the
> docstring).
>
Okay, I'll pass `nil' instead. I'm not sure any other value makes
sense.
> Also, why `substring-no-properties'?
I figured the link should not come with the face properties inherited
from `org-store-link'. If that's incorrect, I'll drop it. It seems to
work either way.
--
-Kenny
next prev parent reply other threads:[~2023-12-11 21:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 13:26 Org-capture %K "Link to the currently clocked task" link with id? Nathaniel W Griswold
2021-05-19 17:29 ` Nathaniel W Griswold
2021-05-24 12:25 ` Nathaniel W Griswold
2021-05-29 8:10 ` Ihor Radchenko
2023-12-07 18:53 ` [PATCH] lisp/org-capture.el: use link ID's for %K Kenny Ballou
2023-12-08 13:56 ` Ihor Radchenko
2023-12-08 18:47 ` Kenny Ballou
2023-12-08 19:01 ` Ihor Radchenko
2023-12-09 22:53 ` Kenny Ballou
2023-12-10 12:19 ` Ihor Radchenko
2023-12-11 15:33 ` Kenny Ballou
2023-12-11 15:46 ` Kenny Ballou
[not found] ` <20231211154357.23020-1-kb@devnulllabs.io>
[not found] ` <87ttoo7dna.fsf@localhost>
2023-12-11 21:21 ` Kenny Ballou [this message]
2023-12-12 4:13 ` [PATCH] lisp/org-capture.el: use `org-store-link' for %K values Kenny Ballou
2023-12-12 4:32 ` Kenny Ballou
2023-12-12 4:32 ` [PATCH] lisp/org-capture.el: use `org-store-link' for %K values Kenny Ballou
2023-12-12 12:46 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ew8m6f.fsf@devnulllabs.io \
--to=kb@devnulllabs.io \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).