emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Following gnus links: Don't mark unrelated articles read
@ 2012-04-22 16:23 Matt Lundin
  2012-04-22 16:29 ` Matt Lundin
  2012-04-23  7:19 ` Bastien
  0 siblings, 2 replies; 3+ messages in thread
From: Matt Lundin @ 2012-04-22 16:23 UTC (permalink / raw)
  To: Org Mode


* lisp/org-gnus.el: (org-gnus-follow-link): Fix argument to
  gnus-group-read-group so that following a link does not result in
  unread article being selected.

The NO-ARTICLE argument to gnus-group-read-group should be t.
Otherwise org-gnus-follow-link selects the most unread article in a
group before selecting the linked article. This results in unread
articles being unread (which can cause one to miss important mail).
---
 lisp/org-gnus.el |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
index 5b855c2..50d91be 100644
--- a/lisp/org-gnus.el
+++ b/lisp/org-gnus.el
@@ -272,7 +272,7 @@ If `org-store-link' was called with a prefix arg the meaning of
 			       ;; stop on integer overflows
 			       (> articles 0))
 		     (setq group-opened (gnus-group-read-group
-					 articles nil group)
+					 articles t group)
 			   articles (if (< articles 16)
 					(1+ articles)
 				      (* articles 2))))
-- 
1.7.10

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Following gnus links: Don't mark unrelated articles read
  2012-04-22 16:23 [PATCH] Following gnus links: Don't mark unrelated articles read Matt Lundin
@ 2012-04-22 16:29 ` Matt Lundin
  2012-04-23  7:19 ` Bastien
  1 sibling, 0 replies; 3+ messages in thread
From: Matt Lundin @ 2012-04-22 16:29 UTC (permalink / raw)
  To: Org Mode

Matt Lundin <mdl@imapmail.org> writes:

> * lisp/org-gnus.el: (org-gnus-follow-link): Fix argument to
>   gnus-group-read-group so that following a link does not result in
>   unread article being selected.
>
> The NO-ARTICLE argument to gnus-group-read-group should be t.
> Otherwise org-gnus-follow-link selects the most unread article in a
> group before selecting the linked article. This results in unread
> articles being unread (which can cause one to miss important mail).
           ^^^^^^^^^^^^
The above should read "being marked read."

> ---
>  lisp/org-gnus.el |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el
> index 5b855c2..50d91be 100644
> --- a/lisp/org-gnus.el
> +++ b/lisp/org-gnus.el
> @@ -272,7 +272,7 @@ If `org-store-link' was called with a prefix arg the meaning of
>  			       ;; stop on integer overflows
>  			       (> articles 0))
>  		     (setq group-opened (gnus-group-read-group
> -					 articles nil group)
> +					 articles t group)
>  			   articles (if (< articles 16)
>  					(1+ articles)
>  				      (* articles 2))))

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Following gnus links: Don't mark unrelated articles read
  2012-04-22 16:23 [PATCH] Following gnus links: Don't mark unrelated articles read Matt Lundin
  2012-04-22 16:29 ` Matt Lundin
@ 2012-04-23  7:19 ` Bastien
  1 sibling, 0 replies; 3+ messages in thread
From: Bastien @ 2012-04-23  7:19 UTC (permalink / raw)
  To: Matt Lundin; +Cc: Org Mode

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> * lisp/org-gnus.el: (org-gnus-follow-link): Fix argument to
>   gnus-group-read-group so that following a link does not result in
>   unread article being selected.

Applied, thanks.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-04-23  7:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-22 16:23 [PATCH] Following gnus links: Don't mark unrelated articles read Matt Lundin
2012-04-22 16:29 ` Matt Lundin
2012-04-23  7:19 ` Bastien

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).