* PATCH: follow timestamp link also in heading
@ 2012-05-23 16:48 Ingo Lohmar
2012-05-23 17:03 ` Ingo Lohmar
0 siblings, 1 reply; 5+ messages in thread
From: Ingo Lohmar @ 2012-05-23 16:48 UTC (permalink / raw)
To: emacs-orgmode
Hi there,
I stumbled upon the functionality to open the agenda for a timestamp
using org-open-at-point. That is really sweet, but as it turns out, it
does not work in a headline (as of 7.8.10, with no changes to the
relevant code since then). I cannot see a good reason for this, and it
is a one-line patch to fix it. Sorry for not using the development
version proper, hence just a unified diff (below).
It would be great if this could be included!
Ingo
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9606,6 +9606,7 @@
(org-remove-occur-highlights nil nil t)
(cond
((and (org-at-heading-p)
+ (not (org-at-timestamp-p))
(not (org-in-regexp
(concat org-plain-link-re "\\|"
org-bracket-link-regexp "\\|"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: follow timestamp link also in heading
2012-05-23 16:48 PATCH: follow timestamp link also in heading Ingo Lohmar
@ 2012-05-23 17:03 ` Ingo Lohmar
2012-05-24 9:34 ` Bastien
2012-05-24 15:58 ` Samuel Wales
0 siblings, 2 replies; 5+ messages in thread
From: Ingo Lohmar @ 2012-05-23 17:03 UTC (permalink / raw)
To: emacs-orgmode
Dammit. Should work (as in normal text) with inactive timestamps as
well! See below.
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -9606,6 +9606,7 @@
(org-remove-occur-highlights nil nil t)
(cond
((and (org-at-heading-p)
+ (not (org-at-timestamp-p t))
(not (org-in-regexp
(concat org-plain-link-re "\\|"
org-bracket-link-regexp "\\|"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: follow timestamp link also in heading
2012-05-23 17:03 ` Ingo Lohmar
@ 2012-05-24 9:34 ` Bastien
2012-05-24 15:58 ` Samuel Wales
1 sibling, 0 replies; 5+ messages in thread
From: Bastien @ 2012-05-24 9:34 UTC (permalink / raw)
To: Ingo Lohmar; +Cc: emacs-orgmode
Hi Ingo,
Ingo Lohmar <i.lohmar@gmail.com> writes:
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -9606,6 +9606,7 @@
> (org-remove-occur-highlights nil nil t)
> (cond
> ((and (org-at-heading-p)
> + (not (org-at-timestamp-p t))
> (not (org-in-regexp
> (concat org-plain-link-re "\\|"
> org-bracket-link-regexp "\\|"
Applied in master, thanks.
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: follow timestamp link also in heading
2012-05-23 17:03 ` Ingo Lohmar
2012-05-24 9:34 ` Bastien
@ 2012-05-24 15:58 ` Samuel Wales
2012-05-25 22:14 ` Bastien
1 sibling, 1 reply; 5+ messages in thread
From: Samuel Wales @ 2012-05-24 15:58 UTC (permalink / raw)
To: Ingo Lohmar; +Cc: emacs-orgmode
Thanks for this. I use inactive timestamps in headings all the time
and sort by them. It offers excellent usability for finding a contact
-- just scan the dates in order.
I had not noticed the /lack/ of the feature, because I didn't notice
its /presence/ in non-mouse.
I use RET to follow links.
Perhaps we should make RET do this also when RET follows links.
Samuel
--
The Kafka Pandemic: http://thekafkapandemic.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: follow timestamp link also in heading
2012-05-24 15:58 ` Samuel Wales
@ 2012-05-25 22:14 ` Bastien
0 siblings, 0 replies; 5+ messages in thread
From: Bastien @ 2012-05-25 22:14 UTC (permalink / raw)
To: Samuel Wales; +Cc: Ingo Lohmar, emacs-orgmode
Samuel Wales <samologist@gmail.com> writes:
> Perhaps we should make RET do this also when RET follows links.
Indeed, that's now the case.
Thanks!
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-05-25 23:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-05-23 16:48 PATCH: follow timestamp link also in heading Ingo Lohmar
2012-05-23 17:03 ` Ingo Lohmar
2012-05-24 9:34 ` Bastien
2012-05-24 15:58 ` Samuel Wales
2012-05-25 22:14 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).