* [PATCH] Fix message format in org-notmuch-search-open
@ 2015-05-15 16:11 Christopher League
2015-05-17 8:27 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Christopher League @ 2015-05-15 16:11 UTC (permalink / raw)
To: emacs-orgmode; +Cc: Christopher League
* org-notmuch.el (org-notmuch-search-open): Bug fix
When opening a notmuch-search link, we use =message= to display the
path at the bottom of the screen. This would signal "Not enough
arguments for format string" when the path contained %-signs, as it is
likely to when the query contains spaces:
[[notmuch-search:tag:inbox%2520not%2520tag:bulk%2520org]]
That query appears to be double-escaped, which also might contribute
to the problem, but either way: we should use =(message "%s" str)= to
print arbitrary strings, not =(message str)=.
---
contrib/lisp/org-notmuch.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/lisp/org-notmuch.el b/contrib/lisp/org-notmuch.el
index ae9b50b..712ec5a 100644
--- a/contrib/lisp/org-notmuch.el
+++ b/contrib/lisp/org-notmuch.el
@@ -113,7 +113,7 @@ Can link to more than one message, if so all matching messages are shown."
(defun org-notmuch-search-open (path)
"Follow a notmuch message link specified by PATH."
- (message path)
+ (message "%s" path)
(funcall org-notmuch-search-open-function path))
(defun org-notmuch-search-follow-link (search)
--
2.4.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix message format in org-notmuch-search-open
2015-05-15 16:11 [PATCH] Fix message format in org-notmuch-search-open Christopher League
@ 2015-05-17 8:27 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2015-05-17 8:27 UTC (permalink / raw)
To: Christopher League; +Cc: emacs-orgmode
Hello,
Christopher League <league@contrapunctus.net> writes:
> * org-notmuch.el (org-notmuch-search-open): Bug fix
> When opening a notmuch-search link, we use =message= to display the
> path at the bottom of the screen. This would signal "Not enough
> arguments for format string" when the path contained %-signs, as it is
> likely to when the query contains spaces:
> [[notmuch-search:tag:inbox%2520not%2520tag:bulk%2520org]]
Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-17 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 16:11 [PATCH] Fix message format in org-notmuch-search-open Christopher League
2015-05-17 8:27 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).