From: Kyle Meyer <kyle@kyleam.com>
To: Robert Klein <roklein@roklein.de>
Cc: emacs-orgmode@gnu.org, monnier@iro.umontreal.ca
Subject: Re: current head croaks on export since commit "Backport commit 3a5f751 from Emacs master branch"
Date: Mon, 10 Aug 2015 10:30:23 -0400 [thread overview]
Message-ID: <87oaifcj28.fsf@kmlap.domain.org> (raw)
In-Reply-To: <20150810090440.56afc9f5@pckr150.mpip-mainz.mpg.de> (Robert Klein's message of "Mon, 10 Aug 2015 09:04:40 +0200")
Robert Klein <roklein@roklein.de> wrote:
> Hi,
>
> when I export a file with current org main I get the following error
> (git-bisect-identified commit below):
[...]
> git bisect bad
> ef9637030456b153fd834f4c9202a9264d5ef18d is the first bad commit
> commit ef9637030456b153fd834f4c9202a9264d5ef18d
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Sat Aug 8 19:41:57 2015 -0400
>
> Backport commit 3a5f751 from Emacs master branch
Thank you for the report.
> If the changes in the commit are Ok, there should perhaps be a check in
> org-check-agenda-file:
>
> (defun org-check-agenda-file (file)
> "Make sure FILE exists. If not, ask user what to do."
> (when (not (string-p file))
> do something else...
Based on the backtrace, I think this is another instance like 11e8749
("org-clock: Fix org-agenda-prepare-buffers call", 2015-08-09), where
org-agenda-prepare-buffers was being called with '(nil)' for the list of
files.
The backport changed a '(while (setq VAR (pop LIST)))' to
'(dolist (VAR LIST))', which exposes this, but '(nil)' should not be
passed as a list of files in the first place.
I'll have a closer look.
--
Kyle
next prev parent reply other threads:[~2015-08-10 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 7:04 current head croaks on export since commit "Backport commit 3a5f751 from Emacs master branch" Robert Klein
2015-08-10 14:30 ` Kyle Meyer [this message]
2015-08-10 16:26 ` Kyle Meyer
2015-08-11 5:58 ` Robert Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaifcj28.fsf@kmlap.domain.org \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=roklein@roklein.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).