From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kyle Meyer <kyle@kyleam.com>
Subject: Re: current head croaks on export since commit "Backport commit
 3a5f751 from Emacs master branch"
Date: Mon, 10 Aug 2015 10:30:23 -0400
Message-ID: <87oaifcj28.fsf@kmlap.domain.org>
References: <20150810090440.56afc9f5@pckr150.mpip-mainz.mpg.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZOo5u-0004SC-7l
	for emacs-orgmode@gnu.org; Mon, 10 Aug 2015 10:30:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZOo5p-0005Bj-9G
	for emacs-orgmode@gnu.org; Mon, 10 Aug 2015 10:30:29 -0400
Received: from mail-qk0-f182.google.com ([209.85.220.182]:35317)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kyle@kyleam.com>) id 1ZOo5p-0005Bb-5c
	for emacs-orgmode@gnu.org; Mon, 10 Aug 2015 10:30:25 -0400
Received: by qkbm65 with SMTP id m65so58592193qkb.2
	for <emacs-orgmode@gnu.org>; Mon, 10 Aug 2015 07:30:24 -0700 (PDT)
In-Reply-To: <20150810090440.56afc9f5@pckr150.mpip-mainz.mpg.de> (Robert
	Klein's message of "Mon, 10 Aug 2015 09:04:40 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Robert Klein <roklein@roklein.de>
Cc: emacs-orgmode@gnu.org, monnier@iro.umontreal.ca

Robert Klein <roklein@roklein.de> wrote:
> Hi,
>
> when I export a file with current org main I get the following error
> (git-bisect-identified commit below):
[...]
>  git bisect bad
> ef9637030456b153fd834f4c9202a9264d5ef18d is the first bad commit
> commit ef9637030456b153fd834f4c9202a9264d5ef18d
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Date:   Sat Aug 8 19:41:57 2015 -0400
>
>     Backport commit 3a5f751 from Emacs master branch

Thank you for the report.

> If the changes in the commit are Ok, there should perhaps be a check in
> org-check-agenda-file:
>
> (defun org-check-agenda-file (file)
>   "Make sure FILE exists.  If not, ask user what to do."
>   (when (not (string-p file))
>       do something else...

Based on the backtrace, I think this is another instance like 11e8749
("org-clock: Fix org-agenda-prepare-buffers call", 2015-08-09), where
org-agenda-prepare-buffers was being called with '(nil)' for the list of
files.

The backport changed a '(while (setq VAR (pop LIST)))' to
'(dolist (VAR LIST))', which exposes this, but '(nil)' should not be
passed as a list of files in the first place.

I'll have a closer look.

--
Kyle