* [PATCH] org-notify: Fix compatibility with latest org-element (uppercase properties)
@ 2015-08-24 13:47 Peter Münster
2015-08-24 20:45 ` Nicolas Goaziou
0 siblings, 1 reply; 3+ messages in thread
From: Peter Münster @ 2015-08-24 13:47 UTC (permalink / raw)
To: emacs-orgmode
* contrib/lisp/org-notify.el (org-notify-make-todo): Properties from
org-element are all uppercase now.
* (org-notify-maybe-too-late): Fix typo in docstring (thanks to davemq,
https://github.com/p-m/org-notify/issues/3).
---
contrib/lisp/org-notify.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/lisp/org-notify.el b/contrib/lisp/org-notify.el
index da2c96f..8bcca9f 100644
--- a/contrib/lisp/org-notify.el
+++ b/contrib/lisp/org-notify.el
@@ -120,7 +120,7 @@ simple timestamp string."
"Create one todo item."
(macrolet ((get (k) `(plist-get list ,k))
(pr (k v) `(setq result (plist-put result ,k ,v))))
- (let* ((list (nth 1 heading)) (notify (or (get :notify) "default"))
+ (let* ((list (nth 1 heading)) (notify (or (get :NOTIFY) "default"))
(deadline (org-notify-convert-deadline (get :deadline)))
(heading (get :raw-value))
result)
@@ -148,7 +148,7 @@ simple timestamp string."
'headline 'org-notify-make-todo)))))
(defun org-notify-maybe-too-late (diff period heading)
- "Print waring message, when notified significantly later than defined by
+ "Print warning message, when notified significantly later than defined by
PERIOD."
(if (> (/ diff period) 1.5)
(message "Warning: notification for \"%s\" behind schedule!" heading))
--
2.1.4
Peter
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] org-notify: Fix compatibility with latest org-element (uppercase properties)
2015-08-24 13:47 [PATCH] org-notify: Fix compatibility with latest org-element (uppercase properties) Peter Münster
@ 2015-08-24 20:45 ` Nicolas Goaziou
2015-08-24 23:53 ` Peter Münster
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2015-08-24 20:45 UTC (permalink / raw)
To: Peter Münster; +Cc: emacs-orgmode
Hello,
Peter Münster <pmlists@free.fr> writes:
> * contrib/lisp/org-notify.el (org-notify-make-todo): Properties from
> org-element are all uppercase now.
> * (org-notify-maybe-too-late): Fix typo in docstring (thanks to davemq,
> https://github.com/p-m/org-notify/issues/3).
Applied. Thank you.
Out of curiosity, as org-notify.el's author, don't you have write access
into repository? If that's the case, you don't need to wait for review.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] org-notify: Fix compatibility with latest org-element (uppercase properties)
2015-08-24 20:45 ` Nicolas Goaziou
@ 2015-08-24 23:53 ` Peter Münster
0 siblings, 0 replies; 3+ messages in thread
From: Peter Münster @ 2015-08-24 23:53 UTC (permalink / raw)
To: emacs-orgmode
On Mon, Aug 24 2015, Nicolas Goaziou wrote:
> Out of curiosity, as org-notify.el's author, don't you have write access
> into repository?
I guess no, but I've never tried...
--
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-24 23:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-24 13:47 [PATCH] org-notify: Fix compatibility with latest org-element (uppercase properties) Peter Münster
2015-08-24 20:45 ` Nicolas Goaziou
2015-08-24 23:53 ` Peter Münster
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).