emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Reuben Thomas <rrt@sc3d.org>
Cc: "emacs-orgmode@gnu.org" <emacs-orgmode@gnu.org>
Subject: Re: Bug: Fix for org-make-link-description-function use in org-insert-link [9.0.10 (9.0.10-5-g1654a5-elpa @ /home/rrt/.emacs.d/elpa/org-20170904/)]
Date: Wed, 06 Sep 2017 00:02:39 +0200	[thread overview]
Message-ID: <87o9qols74.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAOnWdogprVG7wTFtaVQ0XOhd9E3iGOqVDya5orb_Z+XNc7X+ug@mail.gmail.com> (Reuben Thomas's message of "Tue, 5 Sep 2017 22:05:59 +0100")

Reuben Thomas <rrt@sc3d.org> writes:

> ​If you (or someone) can confirm your interpretation above, I would be
> happy to update my patch to implement the two behaviours required, namely,
> that org-make-link-description-function is only called if the
> default-description argument to org-insert-link is nil

Ack.

> and that if that function returns nil, then the link location is used.
> I would also clarify the docstring regarding the second behaviour.

It may not be a terribly useful behaviour anyway. You can always use
(lambda (link description) link) as
`org-make-link-description-function'.

Perhaps we can simply remove "When nil, the link location will be used"
from the docstring. Your call.

Thank you.

Regards,

  reply	other threads:[~2017-09-05 22:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 16:27 Bug: Fix for org-make-link-description-function use in org-insert-link [9.0.10 (9.0.10-5-g1654a5-elpa @ /home/rrt/.emacs.d/elpa/org-20170904/)] Reuben Thomas
2017-09-05 20:49 ` Nicolas Goaziou
2017-09-05 21:05   ` Reuben Thomas
2017-09-05 22:02     ` Nicolas Goaziou [this message]
2017-09-07 23:06       ` Reuben Thomas
2017-09-08  5:00         ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9qols74.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=rrt@sc3d.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).