From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Bug: Fix for org-make-link-description-function use in org-insert-link [9.0.10 (9.0.10-5-g1654a5-elpa @ /home/rrt/.emacs.d/elpa/org-20170904/)] Date: Wed, 06 Sep 2017 00:02:39 +0200 Message-ID: <87o9qols74.fsf@nicolasgoaziou.fr> References: <874lsh5cwj.fsf@sc3d.org> <87a828na5m.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpLvj-0005Vc-2K for emacs-orgmode@gnu.org; Tue, 05 Sep 2017 18:02:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpLve-0002s0-FI for emacs-orgmode@gnu.org; Tue, 05 Sep 2017 18:02:47 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:33183) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpLve-0002rR-9q for emacs-orgmode@gnu.org; Tue, 05 Sep 2017 18:02:42 -0400 In-Reply-To: (Reuben Thomas's message of "Tue, 5 Sep 2017 22:05:59 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Reuben Thomas Cc: "emacs-orgmode@gnu.org" Reuben Thomas writes: > =E2=80=8BIf you (or someone) can confirm your interpretation above, I wou= ld be > happy to update my patch to implement the two behaviours required, namely, > that org-make-link-description-function is only called if the > default-description argument to org-insert-link is nil Ack. > and that if that function returns nil, then the link location is used. > I would also clarify the docstring regarding the second behaviour. It may not be a terribly useful behaviour anyway. You can always use (lambda (link description) link) as `org-make-link-description-function'. Perhaps we can simply remove "When nil, the link location will be used" from the docstring. Your call. Thank you. Regards,