emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Protesilaos Stavrou <info@protesilaos.com>
To: Roman Rudakov <rrudakov@pm.me>
Cc: Ilja Kocken <iljakocken@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)]
Date: Sun, 04 Oct 2020 17:36:47 +0300	[thread overview]
Message-ID: <87o8lit5vk.fsf@protesilaos.com> (raw)
In-Reply-To: <87d025ypu1.fsf@pm.me> (Roman Rudakov's message of "Tue, 29 Sep 2020 08:00:57 +0000")

On 2020-09-29, 08:00 +0000, Roman Rudakov <rrudakov@pm.me> wrote:

> "Protesilaos Stavrou" <info@protesilaos.com> writes:
>> Roman Rudakov <rrudakov@pm.me> [2020-09-15, 18:50 +0000]:
>>> I use theme which draw boxes around priority cookie. Before updating to
>>> version 9.4 box was rendered just around square brackets, but since
>>> version 9.4 it has additional space at the end.
>>> I think it's related to the fact that org-priority face definition used
>>> to use separate regex which didn't include space, and now it uses
>>> variable org-priority-regexp which does include additional space
>>> character.
>>> [...]
>> This issue is noticeable with any face properties for 'org-priority'
>> such as box, background, underline, overline.
>> Just to add a reproducible recipe for this case.
>> On 'emacs -Q' running Org 9.4:
>> + C-x C-f /tmp/test.org
>> + Insert a heading, like:
>>     * TODO [#A] This is a test
>> …see attached screenshot with "default" state.
>> * Now evaluate the following expression:
>>     (set-face-attribute 'org-priority nil :underline t)
>> …see attached screenshot with "edited" state.
>> --
>> Protesilaos Stavrou
>> protesilaos.com
> Hello,
> I think proper value for `org-priority-regex` should be
> ".*?\\(\\[#\\([A-Z0-9]+\\)\\]\\) ?", extra space should be moved out of
> the brackets, It won't break anything and face definition will be
> correct.
> Best regards.

This is to confirm that I and Ilja (in Cc) get the desired behaviour by
evaluating the suggested regexp.

Steps to quickly reproduce this on 'emacs -Q':

+ C-x C-f /tmp/test.org

+ Insert a heading with a priority cookie:

  - * TODO [#A] This is a test

+ Evaluate: (set-face-attribute 'org-priority nil :background "#ddd")

  - The background is just to visualise the extra blank to the right of
    the cookie's closing bracket.  Same principle for underlines,
    overlines, boxes.

+ Eval: (setq org-priority-regexp ".*?\\(\\[#\\([A-Z0-9]+\\)\\]\\) ?")

+ M-x org-mode-restart

+ The extra space which was coloured before should no longer be affected
  by the face properties.  The background we added must only cover the
  priority cookie's text.

Best regards,

Protesilaos Stavrou

  reply	other threads:[~2020-10-04 14:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 18:50 Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)] Roman Rudakov
2020-09-16  8:52 ` Protesilaos Stavrou
2020-09-29  8:00   ` Roman Rudakov
2020-10-04 14:36     ` Protesilaos Stavrou [this message]
2020-10-11  6:40       ` Kyle Meyer
2020-10-12  6:48         ` Protesilaos Stavrou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8lit5vk.fsf@protesilaos.com \
    --to=info@protesilaos.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=iljakocken@gmail.com \
    --cc=rrudakov@pm.me \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).