From: Kyle Meyer <kyle@kyleam.com>
To: Protesilaos Stavrou <info@protesilaos.com>,
Roman Rudakov <rrudakov@pm.me>
Cc: Ilja Kocken <iljakocken@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)]
Date: Sun, 11 Oct 2020 02:40:56 -0400 [thread overview]
Message-ID: <87k0vx8dtz.fsf@kyleam.com> (raw)
In-Reply-To: <87o8lit5vk.fsf@protesilaos.com>
Protesilaos Stavrou writes:
> On 2020-09-29, 08:00 +0000, Roman Rudakov <rrudakov@pm.me> wrote:
>
>> "Protesilaos Stavrou" <info@protesilaos.com> writes:
>>
>>> Roman Rudakov <rrudakov@pm.me> [2020-09-15, 18:50 +0000]:
>>>
>>>> I use theme which draw boxes around priority cookie. Before updating to
>>>> version 9.4 box was rendered just around square brackets, but since
>>>> version 9.4 it has additional space at the end.
>>>>
>>>> I think it's related to the fact that org-priority face definition used
>>>> to use separate regex which didn't include space, and now it uses
>>>> variable org-priority-regexp which does include additional space
>>>> character.
Thanks, all, for the excellent report and debugging.
>> I think proper value for `org-priority-regex` should be
>> ".*?\\(\\[#\\([A-Z0-9]+\\)\\]\\) ?", extra space should be moved out of
>> the brackets, It won't break anything and face definition will be
>> correct.
>
> This is to confirm that I and Ilja (in Cc) get the desired behaviour by
> evaluating the suggested regexp.
I'm wary of changing the regexp. Although the docstring does suggest
the space shouldn't be a part of the first group, the group has included
the space since org-priority-regex was introduced way back in 2008. And
making the suggested change results in a failing test
(test-org/entry-put). So at this point, I'd lean towards adjusting the
docstring.
I've applied a different fix for the regression (b1de0c8e4).
next prev parent reply other threads:[~2020-10-11 6:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 18:50 Roman Rudakov
2020-09-16 8:52 ` Protesilaos Stavrou
2020-09-29 8:00 ` Roman Rudakov
2020-10-04 14:36 ` Protesilaos Stavrou
2020-10-11 6:40 ` Kyle Meyer [this message]
2020-10-12 6:48 ` Protesilaos Stavrou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0vx8dtz.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=iljakocken@gmail.com \
--cc=info@protesilaos.com \
--cc=rrudakov@pm.me \
--subject='Re: Bug: org-priority face has extra space at the end starting from version 9.4 [9.4 (9.4-elpaplus @ /home/rrudakov/.emacs.d/elpa/org-plus-contrib-20200914/)]' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).