emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@gmail.com>
To: numbchild@gmail.com
Cc: Chris Clark <cfclrk@gmail.com>,  emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix void variable error `cider-buffer-ns` when specifying :backend header argument
Date: Wed, 12 Oct 2022 14:04:56 +0800	[thread overview]
Message-ID: <87o7uhshkn.fsf@localhost> (raw)
In-Reply-To: <63460e17.050a0220.1ff7f.4bdeSMTPIN_ADDED_BROKEN@mx.google.com>

"Christopher M. Miles" <numbchild@gmail.com> writes:

> After updated to latest commit, I found error,
>
> Reproduce:
>
> When I specified the `:backend` header argument:
>
> #+begin_src clojure :backend babashka
> (+ 2 4)
> #+end_src
>
> I got error:
>
> #+begin_example
> void variable: cider-buffer-ns
> #+end_example

Thanks for reporting!

> Here is the patch fix upper issue.
>
>    (let* ((vars (org-babel--get-vars params))
> +         (backend-override (cdr (assq :backend params)))
>  	 (ns (or (cdr (assq :ns params))
> -		 (if (eq org-babel-clojure-backend 'cider)
> +		 (if (and (not backend-override)
> +                          (eq org-babel-clojure-backend 'cider))
>  		     (or cider-buffer-ns
>  			 (let ((repl-buf (cider-current-connection)))
>  			   (and repl-buf (buffer-local-value

What if backend-override is 'cider?
I suggest to let-bind
(org-babel-clojure-backend
          (cond
           (backend-override (intern backend-override))
           (org-babel-clojure-backend org-babel-clojure-backend)
           (t (user-error "You need to customize `org-babel-clojure-backend'
or set the `:backend' header argument"))))

Just like in `org-babel-execute:clojure'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

next prev parent reply	other threads:[~2022-10-12  6:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-08 10:24 Add 'backend' header arg to clojure code blocks Chris Clark
2022-10-08 12:43 ` Christopher M. Miles
2022-10-09  7:42 ` Ihor Radchenko
2022-10-09 15:34   ` Chris Clark
2022-10-11  2:55     ` Ihor Radchenko
2022-10-12  0:40       ` [PATCH] Fix void variable error `cider-buffer-ns` when specifying :backend header argument Christopher M. Miles
     [not found]       ` <63460e17.050a0220.1ff7f.4bdeSMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-12  6:04         ` Ihor Radchenko [this message]
2022-10-12  9:29           ` [PATCH] (v2) " Christopher M. Miles
     [not found]           ` <6346892e.050a0220.a2480.498fSMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-13  2:56             ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7uhshkn.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=cfclrk@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=numbchild@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).