From: Ihor Radchenko <yantar92@gmail.com>
To: Chris Clark <cfclrk@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Add 'backend' header arg to clojure code blocks
Date: Sun, 09 Oct 2022 15:42:52 +0800 [thread overview]
Message-ID: <875ygtqw77.fsf@localhost> (raw)
In-Reply-To: <CAL2EVteiBHSnAXnGLqem_hKjYOgo8S8Tm7r6fY5xBiO46UsVkQ@mail.gmail.com>
Chris Clark <cfclrk@gmail.com> writes:
> This is my first attempt to contribute to org-mode; please let me know if
> I'm doing something wrong.
Thanks a lot! Contributions are always welcome.
Please also add a mention and/or example to the ob-clojure documentation
https://orgmode.org/worg/org-contrib/babel/languages/ob-doc-clojure.html
(The source repository is https://git.sr.ht/~bzg/worg )
Also, you need to add an etc/ORG-NEWS entry about the new header
argument.
And I have few minor comments on the patch itself.
> From cc72dcac3075be76e3edcfee75c887272e48698c Mon Sep 17 00:00:00 2001
> From: Chris Clark <cfclrk@gmail.com>
> Date: Sat, 8 Oct 2022 05:41:20 -0400
> Subject: [PATCH] ob-clojure.el: Add a 'backend' header arg to clojure code blocks
^:backend
> * ob-clojure.el (org-babel-header-args:clojure,
> org-babel-execute:clojure): Add a 'backend' header arg that can
^:backend
> override the configured `org-babel-clojure-backend`.
^'
(by convention, we quote like `symbol' using `' pair).
Also, unless you have FSF copyright assignment, we need you to add
TINYCHANGE at the end of the commit message. See
https://orgmode.org/worg/org-contribute.html#first-patch
> + (t (user-error "You need to customize org-babel-clojure-backend")))))
While we are here, can as well quote `org-babel-clojure-backend'.
Or may even add "or set `:backend' header argument".
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2022-10-09 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 10:24 Add 'backend' header arg to clojure code blocks Chris Clark
2022-10-08 12:43 ` Christopher M. Miles
2022-10-09 7:42 ` Ihor Radchenko [this message]
2022-10-09 15:34 ` Chris Clark
2022-10-11 2:55 ` Ihor Radchenko
2022-10-12 0:40 ` [PATCH] Fix void variable error `cider-buffer-ns` when specifying :backend header argument Christopher M. Miles
[not found] ` <63460e17.050a0220.1ff7f.4bdeSMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-12 6:04 ` Ihor Radchenko
2022-10-12 9:29 ` [PATCH] (v2) " Christopher M. Miles
[not found] ` <6346892e.050a0220.a2480.498fSMTPIN_ADDED_BROKEN@mx.google.com>
2022-10-13 2:56 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ygtqw77.fsf@localhost \
--to=yantar92@gmail.com \
--cc=cfclrk@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).