emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug: customize type for `org-agenda-category-icon-alist' [9.3 (release_9.3 @ /usr/share/emacs/27.0.91/lisp/org/)]
@ 2020-07-06 23:00 nilninull
  2020-07-08  4:29 ` Kyle Meyer
  2020-09-05  8:36 ` Bastien
  0 siblings, 2 replies; 4+ messages in thread
From: nilninull @ 2020-07-06 23:00 UTC (permalink / raw)
  To: emacs-orgmode

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

The Emacs customization system is unable to display some parameter types
for the variable `org-agenda-category-icon-alist'.

I encountered this bug when I specified :width and :height.

:width and :height use integers, but the symbol type doesn't parse it well.


diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 90129b23e..b6e92c643 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -2008,7 +2008,7 @@ category, you can use:
                       (string :tag "File or data")
                       (symbol :tag "Type")
                       (boolean :tag "Data?")
-                      (repeat :tag "Extra image properties" :inline t symbol))
+                      (repeat :tag "Extra image properties" :inline t sexp))
                     (list :tag "Display properties" sexp))))

 (defgroup org-agenda-column-view nil


Emacs  : GNU Emacs 27.0.91 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.21, cairo version 1.16.0)
 of 2020-07-06
Package: Org mode version 9.3 (release_9.3 @ /usr/share/emacs/27.0.91/lisp/org/)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: customize type for `org-agenda-category-icon-alist' [9.3 (release_9.3 @ /usr/share/emacs/27.0.91/lisp/org/)]
  2020-07-06 23:00 Bug: customize type for `org-agenda-category-icon-alist' [9.3 (release_9.3 @ /usr/share/emacs/27.0.91/lisp/org/)] nilninull
@ 2020-07-08  4:29 ` Kyle Meyer
  2020-09-05  8:36 ` Bastien
  1 sibling, 0 replies; 4+ messages in thread
From: Kyle Meyer @ 2020-07-08  4:29 UTC (permalink / raw)
  To: nilninull; +Cc: emacs-orgmode

nilninull writes:

> The Emacs customization system is unable to display some parameter types
> for the variable `org-agenda-category-icon-alist'.
>
> I encountered this bug when I specified :width and :height.
>
> :width and :height use integers, but the symbol type doesn't parse it well.
>
>
> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
> index 90129b23e..b6e92c643 100644
> --- a/lisp/org-agenda.el
> +++ b/lisp/org-agenda.el
> @@ -2008,7 +2008,7 @@ category, you can use:
>                        (string :tag "File or data")
>                        (symbol :tag "Type")
>                        (boolean :tag "Data?")
> -                      (repeat :tag "Extra image properties" :inline t symbol))
> +                      (repeat :tag "Extra image properties" :inline t sexp))
>                      (list :tag "Display properties" sexp))))

Looks like a good fix to me.  Would you like to wrap this into a patch
with a commit message?  (Information about contributing is at
<https://orgmode.org/worg/org-contribute.html>.)

Thanks.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: customize type for `org-agenda-category-icon-alist' [9.3 (release_9.3 @ /usr/share/emacs/27.0.91/lisp/org/)]
  2020-07-06 23:00 Bug: customize type for `org-agenda-category-icon-alist' [9.3 (release_9.3 @ /usr/share/emacs/27.0.91/lisp/org/)] nilninull
  2020-07-08  4:29 ` Kyle Meyer
@ 2020-09-05  8:36 ` Bastien
  2020-09-06 15:33   ` nilninull
  1 sibling, 1 reply; 4+ messages in thread
From: Bastien @ 2020-09-05  8:36 UTC (permalink / raw)
  To: nilninull; +Cc: emacs-orgmode

Hi,

applied as 8ae058ebe in the maint branch, thanks.

If you need directions on how to make a patch, please just say so,
it helps a lot by reducing the maintainance burden.

Thanks,

-- 
 Bastien


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Bug: customize type for `org-agenda-category-icon-alist' [9.3 (release_9.3 @ /usr/share/emacs/27.0.91/lisp/org/)]
  2020-09-05  8:36 ` Bastien
@ 2020-09-06 15:33   ` nilninull
  0 siblings, 0 replies; 4+ messages in thread
From: nilninull @ 2020-09-06 15:33 UTC (permalink / raw)
  To: Bastien; +Cc: emacs-orgmode

Got it.

I am sorry for the late reply.

There is no opinion on making the patch.

Thanks.
--
nilninull


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-06 15:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 23:00 Bug: customize type for `org-agenda-category-icon-alist' [9.3 (release_9.3 @ /usr/share/emacs/27.0.91/lisp/org/)] nilninull
2020-07-08  4:29 ` Kyle Meyer
2020-09-05  8:36 ` Bastien
2020-09-06 15:33   ` nilninull

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).