emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Tim Cross <theophilusx@gmail.com>
To: Marco Wahl <marcowahlsoft@gmail.com>
Cc: Colin Baxter <m43cap@yandex.com>, emacs-orgmode@gnu.org
Subject: Re: [WDYT] org-attach-sync better remove an empty attachment directory?
Date: Fri, 09 Jul 2021 05:28:43 +1000	[thread overview]
Message-ID: <87mtqwtxi5.fsf@gmail.com> (raw)
In-Reply-To: <87lf6gwsbe.fsf@gmail.com>


Marco Wahl <marcowahlsoft@gmail.com> writes:

> Marco Wahl <marcowahlsoft@gmail.com> writes:
>
>>     Marco> Please recall that only empty attachment directories would be
>>     Marco> removed, so removal of a directory--and in particular one
>>     Marco> that existed before its interpretation as Org
>>     Marco> attachment--wouldn't be a big deal AFAICS.
>>
>>     Tim> Not as confident here. I can imagine workflows and other
>>     Tim> external scripts which might expect a specific directory
>>     Tim> structure that could be broken if a directory was removed (even
>>     Tim> when empty). Hence my suggestion it needs to be something you
>>     Tim> can turn off.
>>
>>     Tim> Likely this is something which should be controllable via a
>>     Tim> custom setting?
>>
>>     Marco> To be honest I'd rather not make another customizable thing
>>     Marco> out of it to keep the overall complexity low.
>>     Marco> 
>>     Marco> OTOH we could easily introduce e.g. customizable
>>     Marco> org-attach-delete-empty-dirs-on-sync.
>>
>>     Tim> Appreciate the problem with far too many customization options,
>>     Tim> but when it comes to software 'automatically' doing something,
>>     Tim> like removal of an empty directory, especially when it might
>>     Tim> not have been responsible for creation of the directory, it is
>>     Tim> better to provide some way to allow the user to turn off the
>>     Tim> behaviour. I would default to having it enabled though.
>>
>>     Colin> I'm afraid I for one often have empty attach directories
>>     Colin> which I leave alone knowing that one day soon - sometimes
>>     Colin> very soon - they will be used again. Cannot the user be asked
>>     Colin> if he wants the directory removed?
>>
>> Thanks Tim and Colin.
>>
>> We could introduce multiple possibilities to choose from.
>>
>> 1. Ask in case of an empty directory if it should be deleted.
>> 2. Don't ask.  Don't touch an empty directory.  (The state now.)
>> 3. Don't ask.  Delete empty directory.
>>
>> We could also make 3. the default setting.
>
> I made a mistake here.
>
> If we do this I vote for option 1. (not 3.) as default (following the
> suggestion by Colin) since it is the most interactive variant.  If the
> question gets annoying the user can switch to one of the other options.
>

That seems quite resonable to me. 

-- 
Tim Cross


  reply	other threads:[~2021-07-08 20:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 20:15 Marco Wahl
2021-07-08  0:34 ` Tim Cross
2021-07-08  7:45   ` Marco Wahl
2021-07-08  7:56     ` Tim Cross
2021-07-08  8:28       ` Colin Baxter
2021-07-08 17:36         ` Marco Wahl
2021-07-08 18:53           ` Marco Wahl
2021-07-08 19:28             ` Tim Cross [this message]
2021-07-09  6:15               ` Colin Baxter
2021-07-09 19:18                 ` Marco Wahl
2021-07-10 13:20                   ` Colin Baxter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtqwtxi5.fsf@gmail.com \
    --to=theophilusx@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=m43cap@yandex.com \
    --cc=marcowahlsoft@gmail.com \
    --subject='Re: [WDYT] org-attach-sync better remove an empty attachment directory?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).