emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: "Juan Manuel Macías" <maciaschain@posteo.net>
To: excalamus@tutanota.com
Cc: Tim Cross <theophilusx@gmail.com>, orgmode <emacs-orgmode@gnu.org>
Subject: Re: whitespace in org source files
Date: Sat, 13 Nov 2021 12:57:25 +0000	[thread overview]
Message-ID: <87mtm88b7u.fsf@posteo.net> (raw)
In-Reply-To: <MoLHe5v--3-2@tutanota.com> (excalamus's message of "Fri, 12 Nov 2021 23:35:30 +0100 (CET)")

Hi,

excalamus--- via "General discussions about Org-mode." writes:

> I've not used the email contribution style before and have had
> whitespace issues in the past with GitHub PRs.  I typically run
> whitespace-cleanup with the before-save-hook which changes tabs to
> spaces.

I agree with Tim that running whitespace-cleanup is usually a bad idea
within a Git repository. I also have, like you, whitespace-cleanup
hooked to before-save-hook, like a relic of my first Emacs setups. In
case it helps, I have added to my init this function:

(defun my-whitespace-cleanup-no-git ()
    (let ((buf (buffer-file-name)))
      (when (not (vc-git-responsible-p buf))
	(whitespace-cleanup))))

and then:

(add-hook 'before-save-hook 'my-whitespace-cleanup-no-git)

Best regards,

Juan Manuel 


      parent reply	other threads:[~2021-11-13 12:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 22:35 excalamus--- via General discussions about Org-mode.
2021-11-13  2:15 ` Tim Cross
2021-11-13 12:57 ` Juan Manuel Macías [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mtm88b7u.fsf@posteo.net \
    --to=maciaschain@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=excalamus@tutanota.com \
    --cc=theophilusx@gmail.com \
    --subject='Re: whitespace in org source files' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).