* [Patch] org-clock-current-task
@ 2010-02-24 14:39 Bastien
2010-02-24 14:43 ` Carsten Dominik
0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2010-02-24 14:39 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
This patch creates `org-clock-current-task', a new variable to access
the name of the task currently clocked in.
I use it together with erc-bot.el to let people ask me what I'm doing
right now (either from BitlBee/IRC).
Shall I push it?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-clock.el.diff --]
[-- Type: text/x-diff, Size: 958 bytes --]
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index e3866be..fb6fd01 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -944,6 +944,7 @@ the clocking selection, associated with the letter `d'."
(org-back-to-heading t)
(or interrupting (move-marker org-clock-interrupted-task nil))
(org-clock-history-push)
+ (org-clock-set-current)
(cond ((functionp org-clock-in-switch-to-state)
(looking-at org-complex-heading-regexp)
(let ((newstate (funcall org-clock-in-switch-to-state
@@ -1042,6 +1043,11 @@ the clocking selection, associated with the letter `d'."
(message "Clock starts at %s - %s" ts msg-extra)
(run-hooks 'org-clock-in-hook)))))))
+(defvar org-clock-current-task nil
+ "Task currently clocked in.")
+(defun org-clock-set-current ()
+ (setq org-clock-current-task (org-get-heading)))
+
(defun org-clock-mark-default-task ()
"Mark current task as default task."
(interactive)
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Bastien
[-- Attachment #4: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Patch] org-clock-current-task
2010-02-24 14:39 [Patch] org-clock-current-task Bastien
@ 2010-02-24 14:43 ` Carsten Dominik
2010-02-24 14:59 ` Bastien
0 siblings, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-02-24 14:43 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
Yes, please go ahead.
Thanks.
- Carsten
On Feb 24, 2010, at 3:39 PM, Bastien wrote:
> This patch creates `org-clock-current-task', a new variable to access
> the name of the task currently clocked in.
>
> I use it together with erc-bot.el to let people ask me what I'm doing
> right now (either from BitlBee/IRC).
>
> Shall I push it?
>
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index e3866be..fb6fd01 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -944,6 +944,7 @@ the clocking selection, associated with the
> letter `d'."
> (org-back-to-heading t)
> (or interrupting (move-marker org-clock-interrupted-task nil))
> (org-clock-history-push)
> + (org-clock-set-current)
> (cond ((functionp org-clock-in-switch-to-state)
> (looking-at org-complex-heading-regexp)
> (let ((newstate (funcall org-clock-in-switch-to-state
> @@ -1042,6 +1043,11 @@ the clocking selection, associated with the
> letter `d'."
> (message "Clock starts at %s - %s" ts msg-extra)
> (run-hooks 'org-clock-in-hook)))))))
>
> +(defvar org-clock-current-task nil
> + "Task currently clocked in.")
> +(defun org-clock-set-current ()
> + (setq org-clock-current-task (org-get-heading)))
> +
> (defun org-clock-mark-default-task ()
> "Mark current task as default task."
> (interactive)
>
> --
> Bastien
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch] org-clock-current-task
2010-02-24 14:43 ` Carsten Dominik
@ 2010-02-24 14:59 ` Bastien
2010-02-24 15:03 ` Carsten Dominik
0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2010-02-24 14:59 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
Carsten Dominik <carsten.dominik@gmail.com> writes:
> Yes, please go ahead.
Thanks.
Attached is more complete version: now clocking out will set the
content of `org-clock-current-task' to nil.
It occurs to me that such a simple functionnality could also use hooks.
What do you think ? Is it better to include it in the code or to simply
put the hooks on Worg?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-clock.el.diff --]
[-- Type: text/x-diff, Size: 1627 bytes --]
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index e3866be..cb378e6 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -944,6 +944,7 @@ the clocking selection, associated with the letter `d'."
(org-back-to-heading t)
(or interrupting (move-marker org-clock-interrupted-task nil))
(org-clock-history-push)
+ (org-clock-set-current)
(cond ((functionp org-clock-in-switch-to-state)
(looking-at org-complex-heading-regexp)
(let ((newstate (funcall org-clock-in-switch-to-state
@@ -1042,6 +1043,15 @@ the clocking selection, associated with the letter `d'."
(message "Clock starts at %s - %s" ts msg-extra)
(run-hooks 'org-clock-in-hook)))))))
+(defvar org-clock-current-task nil
+ "Task currently clocked in.")
+(defun org-clock-set-current ()
+ "Set `org-clock-current-task' to the task currently clocked in."
+ (setq org-clock-current-task (org-get-heading)))
+(defun org-clock-delete-current ()
+ "Reset `org-clock-current-task' to nil."
+ (setq org-clock-current-task nil))
+
(defun org-clock-mark-default-task ()
"Mark current task as default task."
(interactive)
@@ -1237,7 +1247,8 @@ If there is no running clock, throw an error, unless FAIL-QUIETLY is set."
(force-mode-line-update)
(message (concat "Clock stopped at %s after HH:MM = " org-time-clocksum-format "%s") te h m
(if remove " => LINE REMOVED" ""))
- (run-hooks 'org-clock-out-hook))))))
+ (run-hooks 'org-clock-out-hook)
+ (org-clock-delete-current))))))
(defun org-clock-cancel ()
"Cancel the running clock be removing the start timestamp."
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Bastien
[-- Attachment #4: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Patch] org-clock-current-task
2010-02-24 14:59 ` Bastien
@ 2010-02-24 15:03 ` Carsten Dominik
2010-02-24 15:31 ` Bastien
0 siblings, 1 reply; 5+ messages in thread
From: Carsten Dominik @ 2010-02-24 15:03 UTC (permalink / raw)
To: Bastien; +Cc: emacs-orgmode
No, I think this is good to have - other functionality may want to use
it.
Please check it in.
- Carsten
On Feb 24, 2010, at 3:59 PM, Bastien wrote:
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> Yes, please go ahead.
>
> Thanks.
>
> Attached is more complete version: now clocking out will set the
> content of `org-clock-current-task' to nil.
>
> It occurs to me that such a simple functionnality could also use
> hooks.
> What do you think ? Is it better to include it in the code or to
> simply
> put the hooks on Worg?
>
> <org-clock.el.diff>
> --
> Bastien
- Carsten
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch] org-clock-current-task
2010-02-24 15:03 ` Carsten Dominik
@ 2010-02-24 15:31 ` Bastien
0 siblings, 0 replies; 5+ messages in thread
From: Bastien @ 2010-02-24 15:31 UTC (permalink / raw)
To: Carsten Dominik; +Cc: emacs-orgmode
Carsten Dominik <carsten.dominik@gmail.com> writes:
> No, I think this is good to have - other functionality may want to use
> it.
> Please check it in.
Okay, done!
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-02-24 15:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-24 14:39 [Patch] org-clock-current-task Bastien
2010-02-24 14:43 ` Carsten Dominik
2010-02-24 14:59 ` Bastien
2010-02-24 15:03 ` Carsten Dominik
2010-02-24 15:31 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).