From: Achim Gratz <Stromeko@nexgo.de>
To: emacs-orgmode@gnu.org
Subject: Re: Emacs 22 compatibility
Date: Wed, 19 Dec 2012 10:21:15 +0100 [thread overview]
Message-ID: <87licujt2s.fsf@Rainer.invalid> (raw)
In-Reply-To: 87txrjrlbt.fsf@bzg.ath.cx
Bastien writes:
>> I just tried building. it was successful although there are lot of
>> warnings.
>
> Good to know it builds fine, even with all those warnings.
That's a definition of "builds fine" that I wasn't previously aware of.
As to the question "does it run", yes — sort of. You'll get a bunch of
warning messages each time you open an Org document and I wouldn't trust
it to handle any real data. But that's only a very superficial look
I've had and I certainly didn't use any advance functionality in Org.
As I said, I've already looked into some of these errors and there are
several affecting core functionality.
I've been ignoring when some packages are entirely missing in Emacs 22
(like VM and wanderlust) and assumed that the associated functionality
was unlikely to be used from it. If this is expected to be normal
however, then we should check for the existence of these packages and
conditionalize on the result.
There is another bunch of warnings that is triggered by the fact that
declare-function is doing nothing in Emacs 22. This is used extensively
in the new exporter to avoid circular requires, but there seem to be a
few places where a require or an autoload should have been used instead.
Then comes a longish list of variables and functions that Emacs 22
doesn't yet have (window-system-default-frame-alist) or have a different
signature (like using delete-directory with more than one argument or
kill-buffer with none). Also things like the use of internal or
undocumented variables and functions (e.g. timer--time) that should be
fixed anyway.
The seemingly most serious I've found is that using a defaliased special
form (org-condition-case-unless-debug) inside a macro doesn't seem to be
recognized by the byte compiler and it tries to compile a symbol list as
a function call. Short of yanking out the defalias and replacing with
condition-case, nothing seems to work (maybe another macro expansion
too, haven't had time for this yet).
If I fix things enough so that the test suite will run I'll get this:
Ran 401 tests, 388 results as expected, 13 unexpected
3 expected failures
13 unexpected results:
FAILED ob-exp/evaluate-all-executables-in-order
FAILED ob-exp/export-call-line-information
FAILED ob-exp/exports-both
FAILED ob-exp/exports-inline
FAILED ob-exp/mixed-blocks-with-exports-both
FAILED ob-exp/noweb-no-export-and-exports-both
FAILED ob-exp/noweb-on-export
FAILED ob-exp/noweb-on-export-with-exports-results
FAILED test-org-element/headline-comment-keyword
FAILED test-org-element/headline-interpreter
FAILED test-org/beginning-of-line
FAILED test-org/comment-dwim
FAILED test-org/end-of-line
While this doesn't look so bad on first sight, it will still require a
significant effort to fix and we know that the test suite coverage is
nowhere near complete.
Regards,
Achim.
--
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+
Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds
next prev parent reply other threads:[~2012-12-19 9:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 21:25 Emacs 22 compatibility Achim Gratz
2012-12-15 23:00 ` Nick Dokos
2012-12-16 4:27 ` Jambunathan K
2012-12-16 7:18 ` Achim Gratz
2012-12-18 15:22 ` Bastien
2012-12-18 17:44 ` Achim Gratz
2012-12-18 22:10 ` Yagnesh Raghava Yakkala
2012-12-18 23:29 ` Bastien
2012-12-19 6:46 ` Yagnesh Raghava Yakkala
2012-12-19 9:42 ` Bastien
2012-12-19 9:21 ` Achim Gratz [this message]
2012-12-19 9:41 ` Bastien
2012-12-19 10:18 ` Achim Gratz
2012-12-24 12:53 ` Bastien
2012-12-19 18:54 ` Achim Gratz
2012-12-19 19:13 ` Jambunathan K
2012-12-19 19:20 ` Achim Gratz
2012-12-24 12:52 ` Bastien
2012-12-19 19:13 ` Achim Gratz
2012-12-24 13:03 ` Bastien
2012-12-19 19:02 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87licujt2s.fsf@Rainer.invalid \
--to=stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).