From: Bastien <bzg@altern.org>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Emacs 22 compatibility
Date: Wed, 19 Dec 2012 10:41:27 +0100 [thread overview]
Message-ID: <87bodq9y60.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87licujt2s.fsf@Rainer.invalid> (Achim Gratz's message of "Wed, 19 Dec 2012 10:21:15 +0100")
Hi Achim,
Achim Gratz <Stromeko@nexgo.de> writes:
> That's a definition of "builds fine" that I wasn't previously aware of.
My definition of "building fine" is that the build process does not
break and that it produces the target files. Warnings are not errors
in the process of building, they are pointers to potential problems in
the code that has been built.
> As I said, I've already looked into some of these errors and there are
> several affecting core functionality.
If you or anyone can fix those error, please have a go.
> There is another bunch of warnings that is triggered by the fact that
> declare-function is doing nothing in Emacs 22. This is used extensively
> in the new exporter to avoid circular requires, but there seem to be a
> few places where a require or an autoload should have been used instead.
Yes, I want to clean this up a bit for 8.0.
> If I fix things enough so that the test suite will run I'll get this:
>
> Ran 401 tests, 388 results as expected, 13 unexpected
> 3 expected failures
Well, It's not that bad :)
> 13 unexpected results:
> FAILED ob-exp/evaluate-all-executables-in-order
> FAILED ob-exp/export-call-line-information
> FAILED ob-exp/exports-both
> FAILED ob-exp/exports-inline
> FAILED ob-exp/mixed-blocks-with-exports-both
> FAILED ob-exp/noweb-no-export-and-exports-both
> FAILED ob-exp/noweb-on-export
> FAILED ob-exp/noweb-on-export-with-exports-results
So, this is mostly babel.
> FAILED test-org-element/headline-comment-keyword
> FAILED test-org-element/headline-interpreter
> FAILED test-org/beginning-of-line
> FAILED test-org/comment-dwim
> FAILED test-org/end-of-line
None of the above really counts as "core feature" for me.
> While this doesn't look so bad on first sight, it will still require a
> significant effort to fix and we know that the test suite coverage is
> nowhere near complete.
Yes, agreed.
My time will first go to actual bugs with Emacs 23/24 reported by users,
then to actual bugs in Emacs 22 reported by the users, then to potential
bugs in Emacs 24/23, then to potential bugs in Emacs 22... meaning that
there is little chance for me to work on potential bugs with Emacs 22
(or to review patches for this very quickly.)
Thanks,
--
Bastien
next prev parent reply other threads:[~2012-12-19 9:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-15 21:25 Emacs 22 compatibility Achim Gratz
2012-12-15 23:00 ` Nick Dokos
2012-12-16 4:27 ` Jambunathan K
2012-12-16 7:18 ` Achim Gratz
2012-12-18 15:22 ` Bastien
2012-12-18 17:44 ` Achim Gratz
2012-12-18 22:10 ` Yagnesh Raghava Yakkala
2012-12-18 23:29 ` Bastien
2012-12-19 6:46 ` Yagnesh Raghava Yakkala
2012-12-19 9:42 ` Bastien
2012-12-19 9:21 ` Achim Gratz
2012-12-19 9:41 ` Bastien [this message]
2012-12-19 10:18 ` Achim Gratz
2012-12-24 12:53 ` Bastien
2012-12-19 18:54 ` Achim Gratz
2012-12-19 19:13 ` Jambunathan K
2012-12-19 19:20 ` Achim Gratz
2012-12-24 12:52 ` Bastien
2012-12-19 19:13 ` Achim Gratz
2012-12-24 13:03 ` Bastien
2012-12-19 19:02 ` Achim Gratz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bodq9y60.fsf@bzg.ath.cx \
--to=bzg@altern.org \
--cc=Stromeko@nexgo.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).