From: Bastien <bzg@gnu.org>
To: Viktor Rosenfeld <listuser36@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [BUG] Hotkeys defined in org-tag-alist repeated in agenda filter dispatcher
Date: Mon, 22 Apr 2013 11:26:33 +0200 [thread overview]
Message-ID: <87li8aapbq.fsf@bzg.ath.cx> (raw)
In-Reply-To: <20130422015030.GB7821@cartman> (Viktor Rosenfeld's message of "Mon, 22 Apr 2013 03:50:30 +0200")
[-- Attachment #1: Type: text/plain, Size: 270 bytes --]
Hi Viktor,
Viktor Rosenfeld <listuser36@gmail.com> writes:
> If I hit the =/= key in the agenda to filter the agenda by tag, the
> hotkeys defined in the list above are repeated multiple times.
Can you test this patch against latest maint or master branch?
Thanks,
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-org.el-org-agenda-prepare-buffers-Fix-setting-of-org.patch --]
[-- Type: text/x-patch, Size: 1145 bytes --]
From 4c5a5d0fd1433f82e66344d2038f735c09643e3f Mon Sep 17 00:00:00 2001
From: Bastien Guerry <bzg@altern.org>
Date: Mon, 22 Apr 2013 11:25:39 +0200
Subject: [PATCH] org.el (org-agenda-prepare-buffers): Fix setting of
`org-tag-alist'
* org.el (org-agenda-prepare-buffers): Don't append tags to
`org-tag-alist-for-agenda' when `org-tag-alist-for-agenda' is
not initially set.
Thanks to Viktor Rosenfeld for reporting this.
---
lisp/org.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/org.el b/lisp/org.el
index 70bee87..2f04f1c 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -17974,7 +17974,8 @@ When a buffer is unmodified, it is just killed. When modified, it is saved
(append org-todo-keyword-alist-for-agenda org-todo-key-alist))
(setq org-drawers-for-agenda
(append org-drawers-for-agenda org-drawers))
- (unless (equal org-tag-alist-for-agenda org-tag-alist)
+ (unless (and org-tag-alist-for-agenda
+ (equal org-tag-alist-for-agenda org-tag-alist))
(setq org-tag-alist-for-agenda
(append org-tag-alist-for-agenda org-tag-alist)))
(if org-group-tags
--
1.8.2
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Bastien
next prev parent reply other threads:[~2013-04-22 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 1:50 Viktor Rosenfeld
2013-04-22 9:26 ` Bastien [this message]
2013-04-22 12:01 ` Viktor Rosenfeld
2013-04-24 9:46 ` Bastien
2013-04-24 12:29 ` Viktor Rosenfeld
2013-04-24 13:44 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87li8aapbq.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=listuser36@gmail.com \
--subject='Re: [BUG] Hotkeys defined in org-tag-alist repeated in agenda filter dispatcher' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).