From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [BUG] Hotkeys defined in org-tag-alist repeated in agenda filter dispatcher Date: Mon, 22 Apr 2013 11:26:33 +0200 Message-ID: <87li8aapbq.fsf@bzg.ath.cx> References: <20130422015030.GB7821@cartman> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:60568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUD1C-0008CC-J1 for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 05:26:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUD1B-0001Ia-9A for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 05:26:38 -0400 Received: from mail-wi0-x22c.google.com ([2a00:1450:400c:c05::22c]:47554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUD1B-0001IK-3a for emacs-orgmode@gnu.org; Mon, 22 Apr 2013 05:26:37 -0400 Received: by mail-wi0-f172.google.com with SMTP id hm14so762931wib.5 for ; Mon, 22 Apr 2013 02:26:36 -0700 (PDT) In-Reply-To: <20130422015030.GB7821@cartman> (Viktor Rosenfeld's message of "Mon, 22 Apr 2013 03:50:30 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Viktor Rosenfeld Cc: emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Hi Viktor, Viktor Rosenfeld writes: > If I hit the =/= key in the agenda to filter the agenda by tag, the > hotkeys defined in the list above are repeated multiple times. Can you test this patch against latest maint or master branch? Thanks, --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-org.el-org-agenda-prepare-buffers-Fix-setting-of-org.patch >From 4c5a5d0fd1433f82e66344d2038f735c09643e3f Mon Sep 17 00:00:00 2001 From: Bastien Guerry Date: Mon, 22 Apr 2013 11:25:39 +0200 Subject: [PATCH] org.el (org-agenda-prepare-buffers): Fix setting of `org-tag-alist' * org.el (org-agenda-prepare-buffers): Don't append tags to `org-tag-alist-for-agenda' when `org-tag-alist-for-agenda' is not initially set. Thanks to Viktor Rosenfeld for reporting this. --- lisp/org.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index 70bee87..2f04f1c 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -17974,7 +17974,8 @@ When a buffer is unmodified, it is just killed. When modified, it is saved (append org-todo-keyword-alist-for-agenda org-todo-key-alist)) (setq org-drawers-for-agenda (append org-drawers-for-agenda org-drawers)) - (unless (equal org-tag-alist-for-agenda org-tag-alist) + (unless (and org-tag-alist-for-agenda + (equal org-tag-alist-for-agenda org-tag-alist)) (setq org-tag-alist-for-agenda (append org-tag-alist-for-agenda org-tag-alist))) (if org-group-tags -- 1.8.2 --=-=-= Content-Type: text/plain -- Bastien --=-=-=--