From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Dmitri Makarov <dmakarov@alumni.stanford.edu>
Cc: Alan Schmitt <alan.schmitt@polytechnique.org>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.
Date: Thu, 10 Sep 2015 11:57:01 +0200 [thread overview]
Message-ID: <87lhcesiky.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CANLX=Wj4-ZRaO3X10wSDqqUjLhBFDZ_Sy47mtdxGEwLdKuMPWA@mail.gmail.com> (Dmitri Makarov's message of "Thu, 10 Sep 2015 11:37:36 +0200")
Hello,
Dmitri Makarov <dmakarov@alumni.stanford.edu> writes:
> If you haven't pushed the patch yet, here is attached an updated
> patch, with a correction in the commit message, and a minor correction
> in one of the comments.
Thank you. Some comments follow.
> > On Thu, Sep 10, 2015 at 11:28 AM, Alan Schmitt <alan.schmitt@polytechnique.org> wrote:
>> LGTM (with a tiny caveat that I can fix: the first line of the commit
>> message should not end with a dot). Nicolas, can I push this?
Sure. However, it would be nice to fix the two minor issues below.
> From: Dmitri Makarov <dmakarov@alumni.stanford.edu>
> Date: Wed, 9 Sep 2015 17:24:42 +0200
> Subject: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat
>
> * contrib/lisp/org-mac-link.el: Add new link type "acrobat" to grab
> links to documents open in Adobe Acrobat application.
You need to mention new functions and variables in the commit message.
> +(defun as-get-acrobat-page-link ()
Wrong namespace. It should be prefixed with "org-mac-".
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2015-09-10 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 10:42 [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat Dmitri Makarov
2015-09-09 14:11 ` Alan Schmitt
2015-09-09 15:59 ` Dmitri Makarov
2015-09-10 9:28 ` Alan Schmitt
2015-09-10 9:37 ` Dmitri Makarov
2015-09-10 9:57 ` Nicolas Goaziou [this message]
2015-09-10 10:26 ` Dmitri Makarov
2015-09-10 11:16 ` Alan Schmitt
-- strict thread matches above, loose matches on Subject: below --
2015-06-24 11:43 Dmitri Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lhcesiky.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=alan.schmitt@polytechnique.org \
--cc=dmakarov@alumni.stanford.edu \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).