From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat.
Date: Thu, 10 Sep 2015 11:57:01 +0200
Message-ID: <87lhcesiky.fsf@nicolasgoaziou.fr>
References: <CANLX=WiKvM4nMn5zEyNvhqzSj_-Kd3iiPUNDh8Jz_d8L4-Ci+A@mail.gmail.com>
	<m2d1xrznqp.fsf@charm-ecran.irisa.fr>
	<CANLX=WhXoQZOkEKGH=arK0Wm_RvSw0DgOhGsaaj8YLE=grKDkg@mail.gmail.com>
	<m2zj0uy66v.fsf@charm-ecran.irisa.fr>
	<CANLX=Wj4-ZRaO3X10wSDqqUjLhBFDZ_Sy47mtdxGEwLdKuMPWA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50346)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZZyZg-00072s-2A
	for emacs-orgmode@gnu.org; Thu, 10 Sep 2015 05:55:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZZyZf-0007y4-2Y
	for emacs-orgmode@gnu.org; Thu, 10 Sep 2015 05:55:24 -0400
Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:52851)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1ZZyZe-0007wJ-SN
	for emacs-orgmode@gnu.org; Thu, 10 Sep 2015 05:55:23 -0400
In-Reply-To: <CANLX=Wj4-ZRaO3X10wSDqqUjLhBFDZ_Sy47mtdxGEwLdKuMPWA@mail.gmail.com>
	(Dmitri Makarov's message of "Thu, 10 Sep 2015 11:37:36 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Dmitri Makarov <dmakarov@alumni.stanford.edu>
Cc: Alan Schmitt <alan.schmitt@polytechnique.org>, emacs-orgmode@gnu.org

Hello,

Dmitri Makarov <dmakarov@alumni.stanford.edu> writes:

> If you haven't pushed the patch yet, here is attached an updated
> patch, with a correction in the commit message, and a minor correction
> in one of the comments.

Thank you. Some comments follow.

> > On Thu, Sep 10, 2015 at 11:28 AM, Alan Schmitt <alan.schmitt@polytechnique.org> wrote:

>> LGTM (with a tiny caveat that I can fix: the first line of the commit
>> message should not end with a dot). Nicolas, can I push this?

Sure. However, it would be nice to fix the two minor issues below.

> From: Dmitri Makarov <dmakarov@alumni.stanford.edu>
> Date: Wed, 9 Sep 2015 17:24:42 +0200
> Subject: [PATCH] org-mac-link.el: Handle links to/from Adobe Acrobat
>
> * contrib/lisp/org-mac-link.el: Add new link type "acrobat" to grab
>   links to documents open in Adobe Acrobat application.

You need to mention new functions and variables in the commit message.

> +(defun as-get-acrobat-page-link ()

Wrong namespace. It should be prefixed with "org-mac-".


Regards,

-- 
Nicolas Goaziou