* bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists
[not found] <20120207022015.GC4992@srevilak.net>
@ 2012-02-07 2:43 ` Glenn Morris
[not found] ` <jcvcnjz7lr.fsf@fencepost.gnu.org>
1 sibling, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2012-02-07 2:43 UTC (permalink / raw)
To: Steve Revilak; +Cc: 10745
Steve Revilak wrote:
> Perhaps the value of org-blank-before-new-entry is getting clobbered?
For a start, this:
org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler
is bogus (the relevant syntax is (defvar foo)).
Probably so are these:
org-footnote.el:(defvar org-export-footnotes-seen nil) ; silence byte-compiler
org-footnote.el:(defvar org-export-footnotes-data nil) ; silence byte-compiler
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists
[not found] ` <jcvcnjz7lr.fsf@fencepost.gnu.org>
@ 2012-02-07 3:01 ` Steve Revilak
2012-02-14 14:00 ` Chong Yidong
1 sibling, 0 replies; 3+ messages in thread
From: Steve Revilak @ 2012-02-07 3:01 UTC (permalink / raw)
To: Glenn Morris; +Cc: 10745
[-- Attachment #1.1: Type: text/plain, Size: 373 bytes --]
>> Perhaps the value of org-blank-before-new-entry is getting clobbered?
>
>For a start, this:
>
>org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler
>
>is bogus (the relevant syntax is (defvar foo)).
Glenn,
I believe you found it.
Applying the change in org-footnote.el.patch (attached) corrects the
vertical spacing issue I noticed.
Steve
[-- Attachment #1.2: org-footnote.el.patch --]
[-- Type: text/x-patch, Size: 499 bytes --]
--- org-footnote.el.ORIG 2012-02-06 21:53:00.068908112 -0500
+++ org-footnote.el 2012-02-06 21:54:01.472540988 -0500
@@ -475,7 +475,7 @@
(org-footnote-create-definition label)
(org-footnote-auto-adjust-maybe)))))
-(defvar org-blank-before-new-entry nil) ; silence byte-compiler
+(defvar org-blank-before-new-entry) ; silence byte-compiler
(defun org-footnote-create-definition (label)
"Start the definition of a footnote with label LABEL."
(interactive "sLabel: ")
[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists
[not found] ` <jcvcnjz7lr.fsf@fencepost.gnu.org>
2012-02-07 3:01 ` Steve Revilak
@ 2012-02-14 14:00 ` Chong Yidong
1 sibling, 0 replies; 3+ messages in thread
From: Chong Yidong @ 2012-02-14 14:00 UTC (permalink / raw)
To: Glenn Morris, Bastien Guerry; +Cc: 10745, Steve Revilak
Glenn Morris <rgm@gnu.org> writes:
this:
>
> org-footnote.el:(defvar org-blank-before-new-entry nil) ; silence byte-compiler
>
> is bogus (the relevant syntax is (defvar foo)).
>
> Probably so are these:
>
> org-footnote.el:(defvar org-export-footnotes-seen nil) ; silence byte-compiler
> org-footnote.el:(defvar org-export-footnotes-data nil) ; silence byte-compiler
I removed the bogus values.
Bastien, could you merge the fix to Org upstream? Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-14 14:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20120207022015.GC4992@srevilak.net>
2012-02-07 2:43 ` bug#10745: 24.0.93; Regression: org-meta-return does not honor vertical spacing in lists Glenn Morris
[not found] ` <jcvcnjz7lr.fsf@fencepost.gnu.org>
2012-02-07 3:01 ` Steve Revilak
2012-02-14 14:00 ` Chong Yidong
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).