emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Commit  bb2848 causes performance problems
@ 2012-02-06 17:09 Marcel van der Boom
  2012-03-22  0:43 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Marcel van der Boom @ 2012-02-06 17:09 UTC (permalink / raw)
  To: Org Mode List

[-- Attachment #1: Type: text/plain, Size: 1458 bytes --]

commit bb28480169558a183fab2330476a49b4fb1aec46 causes major
performance problems in my install.

GNU Emacs 24.0.92.3 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.6)

The relevant change:

diff --git a/lisp/org.el b/lisp/org.el
index 587d298..f670787 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -6301,6 +6301,8 @@ in special contexts.
          (org-list-set-item-visibility (point-at-bol) struct 'children)
        (org-show-entry)
        (show-children)
+       (when (memq 'org-cycle-hide-drawers org-cycle-hook)
+         (org-cycle-hide-drawers 'subtree))
        ;; Fold every list in subtree to top-level items.
        (when (eq org-cycle-include-plain-lists 'integrate)
          (save-excursion

I isolated this commit by using 'git bisect'. 

The problem is very noticeable on a reasonably large org file (about
15000 lines). The behaviour I am seeing is a delay in cursor movement
(and cpu load increasing for the emacs process) when the point is on
the higher outline levels. The delay is less when moving the point
further down the tree, presumably because the subtree below that
particular point gets smaller.

By commenting out the two lines marked in the diff, the delay
disappears completely.

Do I have a configaration error, or is this a bug?

marcel

-- 
Marcel van der Boom  -- http://hsdev.com/mvdb.vcf
HS-Development BV    -- http://www.hsdev.com
We use bitcoin!      -- http://bitcoin.org

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5618 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Commit  bb2848 causes performance problems
  2012-02-06 17:09 Commit bb2848 causes performance problems Marcel van der Boom
@ 2012-03-22  0:43 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2012-03-22  0:43 UTC (permalink / raw)
  To: Marcel van der Boom; +Cc: Org Mode List

Hi Marcel,

Marcel van der Boom <marcel@hsdev.com> writes:

> commit bb28480169558a183fab2330476a49b4fb1aec46 causes major
> performance problems in my install.

thanks a lot for reporting this -- the gain in speed when commenting 
the culprit lines out is clear.  I added a FIXME to find another way 
of folding drawers in subtrees.

Thanks again!

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-03-22  9:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-06 17:09 Commit bb2848 causes performance problems Marcel van der Boom
2012-03-22  0:43 ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).