emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* Bug:install: cannot stat ‘org-install.elc’
@ 2012-10-03  8:34 Ian Barton
  2012-10-03  8:51 ` Achim Gratz
  0 siblings, 1 reply; 12+ messages in thread
From: Ian Barton @ 2012-10-03  8:34 UTC (permalink / raw)
  To: emacs-orgmode

Just done a git pull followed by make clean, make all and make install. 
I get the following error:

install: cannot stat ‘org-install.elc’: No such file or directory
make[1]: *** [install] Error 1
make[1]: Leaving directory `/home/ian/Dropbox/.emacs.d/src/org-mode/lisp'
make: *** [install-lisp] Error 2

Looking in the lisp directory I have an org-install.el but no .elc file, 
so it looks as thought he makefile isn't compiling it.

Ian.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-03  8:34 Bug:install: cannot stat ‘org-install.elc’ Ian Barton
@ 2012-10-03  8:51 ` Achim Gratz
  2012-10-03 10:24   ` Bastien
  0 siblings, 1 reply; 12+ messages in thread
From: Achim Gratz @ 2012-10-03  8:51 UTC (permalink / raw)
  To: emacs-orgmode

Ian Barton writes:
> Just done a git pull followed by make clean, make all and make
> install. I get the following error:
>
> install: cannot stat ‘org-install.elc’: No such file or directory
> make[1]: *** [install] Error 1
> make[1]: Leaving directory `/home/ian/Dropbox/.emacs.d/src/org-mode/lisp'
> make: *** [install-lisp] Error 2
>
> Looking in the lisp directory I have an org-install.el but no .elc
> file, so it looks as thought he makefile isn't compiling it.

Remove org-install.el that has been left over from a previous build.

To everyone else: the build system has been broken by the recent changes
in multiple ways.  Depending on what your local.mk contains it may or
may not affect you, but I'd advise you to stay clear of all targets
dealing with installation (and cleaning of installation).


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Waldorf MIDI Implementation & additional documentation:
http://Synth.Stromeko.net/Downloads.html#WaldorfDocs

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-03  8:51 ` Achim Gratz
@ 2012-10-03 10:24   ` Bastien
  2012-10-03 12:42     ` Achim Gratz
  0 siblings, 1 reply; 12+ messages in thread
From: Bastien @ 2012-10-03 10:24 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Achim Gratz <Stromeko@nexgo.de> writes:

> To everyone else: the build system has been broken by the recent changes
> in multiple ways.  Depending on what your local.mk contains it may or
> may not affect you, but I'd advise you to stay clear of all targets
> dealing with installation (and cleaning of installation).

I reverted the bad commits and things should be back to normal now.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-03 10:24   ` Bastien
@ 2012-10-03 12:42     ` Achim Gratz
  2012-10-03 16:40       ` Achim Gratz
  0 siblings, 1 reply; 12+ messages in thread
From: Achim Gratz @ 2012-10-03 12:42 UTC (permalink / raw)
  To: emacs-orgmode

Bastien writes:
>> To everyone else: the build system has been broken by the recent changes
>> in multiple ways.  Depending on what your local.mk contains it may or
>> may not affect you, but I'd advise you to stay clear of all targets
>> dealing with installation (and cleaning of installation).
>
> I reverted the bad commits and things should be back to normal now.

Thank you.  I'll have a closer look at the state of the onion later.

One suggestion: I'd introduce an org-install.el that never gets compiled
and only throws a warning if loaded.  This will also help to defuse old
copies of org-install that are maybe still present later in load-path.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-03 12:42     ` Achim Gratz
@ 2012-10-03 16:40       ` Achim Gratz
  2012-10-04 12:01         ` Nicolas Goaziou
  0 siblings, 1 reply; 12+ messages in thread
From: Achim Gratz @ 2012-10-03 16:40 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

Achim Gratz writes:
> One suggestion: I'd introduce an org-install.el that never gets compiled
> and only throws a warning if loaded.  This will also help to defuse old
> copies of org-install that are maybe still present later in load-path.

Here's a patch to that effect:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dummy org-install.el --]
[-- Type: text/x-patch, Size: 2265 bytes --]

From 08b4c62aed7596a4b13d046250af7f8c469a9b1c Mon Sep 17 00:00:00 2001
From: Achim Gratz <Stromeko@Stromeko.DE>
Date: Wed, 3 Oct 2012 18:39:07 +0200
Subject: [PATCH] introduce dummy org-install.el to catch old installations

* lisp/Makefile: Arrange for an uncompiled org-install.el.  This also
  ensures that if there's an old org-install.el in the installation
  directory, it will be replaced and not linger.

* lisp/org-install.el: Provide an empty file that prints a warning
  about an outdated configuration.
---
 lisp/Makefile       |  8 ++++----
 lisp/org-install.el | 13 +++++++++++++
 2 files changed, 17 insertions(+), 4 deletions(-)
 create mode 100644 lisp/org-install.el

diff --git a/lisp/Makefile b/lisp/Makefile
index ef8c625..e2f1768 100644
--- a/lisp/Makefile
+++ b/lisp/Makefile
@@ -7,8 +7,9 @@ endif
 LISPV = org-version.el
 LISPI = org-loaddefs.el
 LISPA = $(LISPV) $(LISPI)
+LISPB = $(LISPA:%el=%elc) org-install.elc
 LISPF = $(filter-out $(LISPA),$(sort $(wildcard *.el)))
-LISPC = $(filter-out $(LISPN:%el=%elc),$(LISPF:%el=%elc))
+LISPC = $(filter-out $(LISPB) $(LISPN:%el=%elc),$(LISPF:%el=%elc))
 _ORGCM_ = dirall single source slint1 slint2
 -include local.mk
 
@@ -65,7 +66,7 @@ $(LISPV):	$(LISPF)
 	@$(MAKE_ORG_VERSION)
 
 $(LISPI):	$(LISPV) $(LISPF)
-	@echo "org-install: $(ORGVERSION) ($(GITVERSION))"
+	@echo "org-loaddefs: $(ORGVERSION) ($(GITVERSION))"
 	@$(RM) $(@)
 	@$(MAKE_ORG_INSTALL)
 
@@ -76,10 +77,9 @@ install:	$(LISPF) compile
 	$(CP) $(LISPC) $(LISPF) $(LISPA) $(DESTDIR)$(lispdir)
 
 cleanauto clean cleanall::
-	$(RM) $(LISPA) $(LISPA:%el=%elc)
+	$(RM) $(LISPA) $(LISPB)
 clean cleanall cleanelc::
 	$(RM) *.elc
-	$(RM) org-install.el # Fix leftover from previous install method
 
 clean-install:
 	if [ -d $(DESTDIR)$(lispdir) ] ; then \
diff --git a/lisp/org-install.el b/lisp/org-install.el
new file mode 100644
index 0000000..a31d8b7
--- /dev/null
+++ b/lisp/org-install.el
@@ -0,0 +1,13 @@
+;;; org-install.el --- autogenerated file, do not edit
+;;
+;;; Code:
+(warn "The file org-install is obsolete.
+Please change your configuration to (require 'org) instead.")
+\f
+(provide 'org-install)
+\f
+;; Local Variables:
+;; no-byte-compile: t
+;; coding: utf-8
+;; End:
+;;; org-install.el ends here
-- 
1.7.12.1


[-- Attachment #3: Type: text/plain, Size: 190 bytes --]



Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-03 16:40       ` Achim Gratz
@ 2012-10-04 12:01         ` Nicolas Goaziou
  2012-10-04 15:47           ` ASSI
  0 siblings, 1 reply; 12+ messages in thread
From: Nicolas Goaziou @ 2012-10-04 12:01 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Hello,

Achim Gratz <Stromeko@nexgo.de> writes:

> Achim Gratz writes:
>> One suggestion: I'd introduce an org-install.el that never gets compiled
>> and only throws a warning if loaded.  This will also help to defuse old
>> copies of org-install that are maybe still present later in load-path.
>
> Here's a patch to that effect:

This looks like a good idea.

AFAIU, this is a temporary fuse. As such, wouldn't it be useful to drop
a note (i.e. as a comment in the Makefile) reminding it and explaining
how to remove it when its time has come ?


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-04 12:01         ` Nicolas Goaziou
@ 2012-10-04 15:47           ` ASSI
  2012-10-05 20:26             ` Nicolas Goaziou
  0 siblings, 1 reply; 12+ messages in thread
From: ASSI @ 2012-10-04 15:47 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: emacs-orgmode

On Thursday 04 October 2012, 14:01:26, Nicolas Goaziou wrote:
> AFAIU, this is a temporary fuse. As such, wouldn't it be useful to drop
> a note (i.e. as a comment in the Makefile) reminding it and explaining
> how to remove it when its time has come ?

Actually, I would leave it in indefinately.  There's just too many 
combinations of potentially old Org installations in load-path and the cost 
of keeping it is negligible.  I've tested it locally by now and it does work 
fine.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-04 15:47           ` ASSI
@ 2012-10-05 20:26             ` Nicolas Goaziou
  2012-10-06  9:19               ` Achim Gratz
  0 siblings, 1 reply; 12+ messages in thread
From: Nicolas Goaziou @ 2012-10-05 20:26 UTC (permalink / raw)
  To: ASSI; +Cc: emacs-orgmode

Hello,

ASSI <Stromeko@nexgo.de> writes:

> Actually, I would leave it in indefinately.  There's just too many 
> combinations of potentially old Org installations in load-path and the cost 
> of keeping it is negligible.  I've tested it locally by now and it does work 
> fine.

Ok. Then, please install it in maint whenever you find it appropriate.


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-05 20:26             ` Nicolas Goaziou
@ 2012-10-06  9:19               ` Achim Gratz
  2012-10-06  9:50                 ` Nicolas Goaziou
  0 siblings, 1 reply; 12+ messages in thread
From: Achim Gratz @ 2012-10-06  9:19 UTC (permalink / raw)
  To: emacs-orgmode

Nicolas Goaziou writes:
> Ok. Then, please install it in maint whenever you find it appropriate.

Done.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-06  9:19               ` Achim Gratz
@ 2012-10-06  9:50                 ` Nicolas Goaziou
  2012-10-06 10:57                   ` Achim Gratz
  0 siblings, 1 reply; 12+ messages in thread
From: Nicolas Goaziou @ 2012-10-06  9:50 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-orgmode

Hello,

Achim Gratz <Stromeko@nexgo.de> writes:

> Nicolas Goaziou writes:
>> Ok. Then, please install it in maint whenever you find it appropriate.
>
> Done.

Thank you.

One problem is that I get the warning every time I call M-x org-reload,
even if my installation is fine otherwise. Is it expected or am
I missing something?


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-06  9:50                 ` Nicolas Goaziou
@ 2012-10-06 10:57                   ` Achim Gratz
  2012-10-07 17:20                     ` Achim Gratz
  0 siblings, 1 reply; 12+ messages in thread
From: Achim Gratz @ 2012-10-06 10:57 UTC (permalink / raw)
  To: emacs-orgmode

Nicolas Goaziou writes:
> One problem is that I get the warning every time I call M-x org-reload,
> even if my installation is fine otherwise. Is it expected or am
> I missing something?

This can only happen if (fetaurep 'org-install) yields true.  In that
case, something has been loading org-install.el and the warning should
be given.  I can arrange for org-reload to filter these out,
org-loaddefs needs special handling as well so I'm in there already.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptation for Waldorf Blofeld V1.15B11:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: Bug:install: cannot stat ‘org-install.elc’
  2012-10-06 10:57                   ` Achim Gratz
@ 2012-10-07 17:20                     ` Achim Gratz
  0 siblings, 0 replies; 12+ messages in thread
From: Achim Gratz @ 2012-10-07 17:20 UTC (permalink / raw)
  To: emacs-orgmode

Achim Gratz writes:
> This can only happen if (fetaurep 'org-install) yields true.  In that
> case, something has been loading org-install.el and the warning should
> be given.  I can arrange for org-reload to filter these out,
> org-loaddefs needs special handling as well so I'm in there already.

A closer look at org-reload revealed that it didn't work as advertised
when files were compressed and/or the corresponding source files were
missing (Cygwin does that by default for instance, you have to install
the source files seperately).  Getting this right has been surprisingly
tricky (and uncovered a few bugs in Org and one or possibly two in
Emacs), so I'm pushing this to master only for now.  I think this should
go into Emacs 24.3 if no new bugs are reported, however.  Test results
and feedback welcome — pushed as 951589.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

SD adaptations for Waldorf Q V3.00R3 and Q+ V3.54R2:
http://Synth.Stromeko.net/Downloads.html#WaldorfSDada

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2012-10-07 17:20 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-03  8:34 Bug:install: cannot stat ‘org-install.elc’ Ian Barton
2012-10-03  8:51 ` Achim Gratz
2012-10-03 10:24   ` Bastien
2012-10-03 12:42     ` Achim Gratz
2012-10-03 16:40       ` Achim Gratz
2012-10-04 12:01         ` Nicolas Goaziou
2012-10-04 15:47           ` ASSI
2012-10-05 20:26             ` Nicolas Goaziou
2012-10-06  9:19               ` Achim Gratz
2012-10-06  9:50                 ` Nicolas Goaziou
2012-10-06 10:57                   ` Achim Gratz
2012-10-07 17:20                     ` Achim Gratz

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).