emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ingo Lohmar <ingo.lohmar@posteo.net>
To: emacs-orgmode@gnu.org
Subject: Bug: missing `save-excursion' in `org-fast-tag-selection' [9.2.3 (9.2.3-9-g0803e2-elpa @ /home/il/.emacs.d/elpa/org-20190422/)]
Date: Sat, 27 Apr 2019 12:45:48 +0200	[thread overview]
Message-ID: <87k1ff20bn.fsf@kenko.localhost.com> (raw)

Hi all, 

I tried to use `org-agenda-set-tags'.  The source buffer (where the
change should be applied) is visible at the same time as the agenda is.
Also, fast tag selection with a single key is enabled.

Under these circumstances, the tag text is appended to the line (not
even necessarily a heading!) where point is in the source buffer visible
next to the agenda, instead of the correct heading that I acted upon.

I tracked this done to a missing `save-excursion' wrapped around the
`save-window-excursion' in `org-fast-tag-selection' (org.el line 14567
in my version).  This would be analogous to what is done in
`org-fast-todo-selection' and fixes my issue.

Thanks!



Emacs  : GNU Emacs 27.0.50 (build 24, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-02-16
Package: Org mode version 9.2.3 (9.2.3-9-g0803e2-elpa @ /home/il/.emacs.d/elpa/org-20190422/)

current state:
==============
(setq
 org-agenda-window-setup 'current-window
 org-fast-tag-selection-single-key t
 org-tag-persistent-alist '(("REFILE" . 82) ("SELECT" . 115)))

next             reply	other threads:[~2019-04-27 10:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-27 10:45 Ingo Lohmar [this message]
2019-04-29 17:21 ` Bug: missing `save-excursion' in `org-fast-tag-selection' [9.2.3 (9.2.3-9-g0803e2-elpa @ /home/il/.emacs.d/elpa/org-20190422/)] Nicolas Goaziou
  -- strict thread matches above, loose matches on Subject: below --
2019-05-01 16:03 Damian
2019-05-09 20:05 ` Nicolas Goaziou
2019-04-26 17:51 Ingo Lohmar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1ff20bn.fsf@kenko.localhost.com \
    --to=ingo.lohmar@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).