From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Lohmar Subject: Bug: missing `save-excursion' in `org-fast-tag-selection' [9.2.3 (9.2.3-9-g0803e2-elpa @ /home/il/.emacs.d/elpa/org-20190422/)] Date: Sat, 27 Apr 2019 12:45:48 +0200 Message-ID: <87k1ff20bn.fsf@kenko.localhost.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([209.51.188.92]:38244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKKqM-00030c-JS for emacs-orgmode@gnu.org; Sat, 27 Apr 2019 06:46:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKKqI-0002rG-CF for emacs-orgmode@gnu.org; Sat, 27 Apr 2019 06:46:04 -0400 Received: from mout02.posteo.de ([185.67.36.66]:43067) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hKKqF-0002j6-SY for emacs-orgmode@gnu.org; Sat, 27 Apr 2019 06:46:00 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 8C64C2400FB for ; Sat, 27 Apr 2019 12:45:49 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 44rndS71vHz9rxL for ; Sat, 27 Apr 2019 12:45:48 +0200 (CEST) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi all, I tried to use `org-agenda-set-tags'. The source buffer (where the change should be applied) is visible at the same time as the agenda is. Also, fast tag selection with a single key is enabled. Under these circumstances, the tag text is appended to the line (not even necessarily a heading!) where point is in the source buffer visible next to the agenda, instead of the correct heading that I acted upon. I tracked this done to a missing `save-excursion' wrapped around the `save-window-excursion' in `org-fast-tag-selection' (org.el line 14567 in my version). This would be analogous to what is done in `org-fast-todo-selection' and fixes my issue. Thanks! Emacs : GNU Emacs 27.0.50 (build 24, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2019-02-16 Package: Org mode version 9.2.3 (9.2.3-9-g0803e2-elpa @ /home/il/.emacs.d/elpa/org-20190422/) current state: ============== (setq org-agenda-window-setup 'current-window org-fast-tag-selection-single-key t org-tag-persistent-alist '(("REFILE" . 82) ("SELECT" . 115)))