From: Ihor Radchenko <yantar92@posteo.net>
To: Karthik Chikmagalur <karthikchikmagalur@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Justify/align image previews in org-mode
Date: Mon, 18 Dec 2023 12:47:46 +0000 [thread overview]
Message-ID: <87jzpbr825.fsf@localhost> (raw)
In-Reply-To: <8734vz3m16.fsf@gmail.com>
Karthik Chikmagalur <karthikchikmagalur@gmail.com> writes:
> Please ignore the previous patch and use this one instead. I've fixed a
> bug and a couple of formatting errors.
Thanks for the patch!
See my comments inline.
> +(defcustom org-image-align nil
> + "How to align images previewed using `org-display-inline-images'.
> +
> +Only stand-alone image links are affected by this setting. These
> +are links without surrounding text.
> +
> +Possible values of this option are:
> +
> +nil Insert image at specified position (same as left-alignment).
It would make sense to allow 'left value as well (same as nil).
> + (when align
> + (overlay-put
> + ov 'before-string
> + (propertize
> + " " 'face 'default
> + 'display
> + (pcase align
> + ((or 'center 'justify)
I do not think that we need to consider 'justify value at this point.
Maybe in future, when (or if) we add proper justification support to
text. But not now.
> +(defun org-image--align (link)
> + "Determine the alignment of the image link.
> +
> +This is controlled globally by the option `org-image-align', and
> +per image by the value of `:align' in the affiliated keyword
> +`#+attr_org'.
> +
> +The result is one of the symbols center, justify or right. The
> +first two will cause the image preview to be centered, the last
> +will cause it to be right-aligned. A return value of nil implies
> +no special alignment -- the image preview is overlaid on the link
> +exactly where it appears in the buffer."
> + (let ((par (org-element-lineage link 'paragraph)))
> + ;; Only apply when image is not surrounded by paragraph text:
> + (when (and (= (org-element-property :begin link)
> + (org-element-property :contents-begin par))
> + (<= (- (org-element-property :contents-end par)
> + (org-element-property :end link))
> + 1)) ;account for trailing newline
This will not work when the image paragraph is indented:
* This is test
#+attr_org: :align center
[[file:~/Downloads/wallpaper.png]]
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
next prev parent reply other threads:[~2023-12-18 12:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 21:19 [PATCH] Justify/align image previews in org-mode Karthik Chikmagalur
2023-12-18 9:19 ` Karthik Chikmagalur
2023-12-18 12:47 ` Ihor Radchenko [this message]
2023-12-18 16:49 ` Karthik Chikmagalur
2023-12-18 17:07 ` Ihor Radchenko
2023-12-18 20:18 ` Karthik Chikmagalur
2023-12-19 2:25 ` Karthik Chikmagalur
2023-12-19 11:44 ` Ihor Radchenko
2023-12-19 19:05 ` Karthik Chikmagalur
2023-12-21 13:42 ` Ihor Radchenko
2023-12-19 11:56 ` Ihor Radchenko
2023-12-25 8:38 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzpbr825.fsf@localhost \
--to=yantar92@posteo.net \
--cc=emacs-orgmode@gnu.org \
--cc=karthikchikmagalur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).