emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@altern.org>
To: Sebastien Vauban <wxhgmqzgwmuf@spammotel.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [patch] Don't output preamble DIV if its contents is empty
Date: Sat, 29 Oct 2011 13:31:41 +0200	[thread overview]
Message-ID: <87ipn8yqxu.fsf@gnu.org> (raw)
In-Reply-To: <80k48ej9ou.fsf@somewhere.org> (Sebastien Vauban's message of "Sun, 09 Oct 2011 20:34:25 +0200")

Hi Sébastien,

"Sebastien Vauban" <wxhgmqzgwmuf@spammotel.com> writes:

>> are there adverse effects when an empty div is in the file?
>
> Yes, there are, reason for such patch.

I understand the reasons and I have applied the patch -- please
provide a ChangeLog next time.  

You can provide it like you just did (with the tag filter patch), but
even better is to include the ChangeLog in the commit log, after the
first line.  

Check available commits on http://orgmode.org/w/org-mode.git to 
get the idea.

Thanks!

-- 
 Bastien

next prev parent reply	other threads:[~2011-10-29 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-29 19:58 [patch] Don't output preamble DIV if its contents is empty Sebastien Vauban
2011-10-09 11:24 ` Carsten Dominik
2011-10-09 18:34   ` Sebastien Vauban
2011-10-29 11:31     ` Bastien [this message]
2011-10-29 19:28       ` Sebastien Vauban
2011-10-30  0:12         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipn8yqxu.fsf@gnu.org \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=wxhgmqzgwmuf@spammotel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).