From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [patch] Don't output preamble DIV if its contents is empty Date: Sat, 29 Oct 2011 13:31:41 +0200 Message-ID: <87ipn8yqxu.fsf@gnu.org> References: <80lit75df7.fsf@somewhere.org> <80k48ej9ou.fsf@somewhere.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([140.186.70.92]:44173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RK77g-0001QD-Ee for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 07:30:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RK77f-0005aO-D5 for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 07:30:48 -0400 Received: from mail-wy0-f169.google.com ([74.125.82.169]:34663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RK77f-0005aH-3g for emacs-orgmode@gnu.org; Sat, 29 Oct 2011 07:30:47 -0400 Received: by wyg34 with SMTP id 34so5651820wyg.0 for ; Sat, 29 Oct 2011 04:30:46 -0700 (PDT) In-Reply-To: <80k48ej9ou.fsf@somewhere.org> (Sebastien Vauban's message of "Sun, 09 Oct 2011 20:34:25 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Sebastien Vauban Cc: emacs-orgmode@gnu.org Hi Sébastien, "Sebastien Vauban" writes: >> are there adverse effects when an empty div is in the file? > > Yes, there are, reason for such patch. I understand the reasons and I have applied the patch -- please provide a ChangeLog next time. You can provide it like you just did (with the tag filter patch), but even better is to include the ChangeLog in the commit log, after the first line. Check available commits on http://orgmode.org/w/org-mode.git to get the idea. Thanks! -- Bastien